From: Francois Romieu <romieu@fr.zoreil.com>
To: Ben Hutchings <benh@debian.org>
Cc: Hayes Wang <hayeswang@realtek.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
David Miller <davem@davemloft.net>,
564628@bugs.debian.org
Subject: Re: [PATCH] net/r8169: Correct the ram code for RTL8111D(L)
Date: Fri, 26 Nov 2010 23:49:14 +0100 [thread overview]
Message-ID: <20101126224914.GA12266@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1290779458.3051.45.camel@localhost>
Ben Hutchings <benh@debian.org> :
> On Fri, 2010-11-26 at 19:54 +0800, Hayes Wang wrote:
> > Correct the binary code (Low pass filter & DLY_CAP fine tune from uC).
> > The incorrect ram code would make the nic working abnormally.
> [...]
>
> I'm glad you finally acknowledge that this is code rather than simple
> register initialisation.
I am not sure that Hayes is a native english speaker.
I am glad to see him posting here.
[...]
> Below are the changes Debian currently applies in preparation for proper
> licencing of the firmware.
Do you have some scripts to convert the data at hand ?
I would welcome a clear statement regarding the status of the binary thing
(code ? data ?) but even without one *now*, I'd like to see it separated
from the main code : the driver sucks and things will go worse with
support code for the 8168e.
Is there anybody objecting to it ? I will buy anything be it firmware API
or plain .h.
--
Ueimor
next prev parent reply other threads:[~2010-11-26 22:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 11:54 Hayes Wang
2010-11-26 13:50 ` Ben Hutchings
2010-11-26 22:49 ` Francois Romieu [this message]
2010-11-26 23:12 ` Ben Hutchings
2010-11-29 3:47 ` hayeswang
2010-11-29 23:33 ` Francois Romieu
2010-11-30 0:13 ` Stephen Hemminger
2010-11-30 6:37 ` hayeswang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101126224914.GA12266@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=564628@bugs.debian.org \
--cc=benh@debian.org \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®