From: hayeswang <hayeswang@realtek.com>
To: "'Ben Hutchings'" <benh@debian.org>,
"'Francois Romieu'" <romieu@fr.zoreil.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"'David Miller'" <davem@davemloft.net>, <564628@bugs.debian.org>
Subject: RE: [PATCH] net/r8169: Correct the ram code for RTL8111D(L)
Date: Mon, 29 Nov 2010 11:47:07 +0800 [thread overview]
Message-ID: <CE0F8B12F31D4E82860F4CE06907E98B@realtek.com.tw> (raw)
In-Reply-To: <1290813146.3051.58.camel@localhost>
Excuse me, I have some questions about the firmware patch.
1. I should convert the data into the binary files (.bin). Is it right?
2. Where should I update the firmware files? Is the path the
linux-2.6/firmeware?
However, according to linux-2.6/firmeware/README.AddingFirmware, I
should
update they to another repository:
git://git.kernel.org/pub/scm/linux/kernel/git/dwmw2/linux-firmware.git
Then, how the firmware merge with kernel-2.6? Or, where could I find the
firmware
in the kernel-2.6 repository?
Best Regards,
Hayes
> -----Original Message-----
> From: Ben Hutchings [mailto:benh@debian.org]
> Sent: Saturday, November 27, 2010 7:12 AM
> To: Francois Romieu; Hayeswang
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> David Miller; 564628@bugs.debian.org
> Subject: Re: [PATCH] net/r8169: Correct the ram code for RTL8111D(L)
>
> On Fri, 2010-11-26 at 23:49 +0100, Francois Romieu wrote:
> > Ben Hutchings <benh@debian.org> :
> > > On Fri, 2010-11-26 at 19:54 +0800, Hayes Wang wrote:
> > > > Correct the binary code (Low pass filter & DLY_CAP fine
> tune from uC).
> > > > The incorrect ram code would make the nic working abnormally.
> > > [...]
> > >
> > > I'm glad you finally acknowledge that this is code rather than
> > > simple register initialisation.
> >
> > I am not sure that Hayes is a native english speaker.
> >
> > I am glad to see him posting here.
>
> Right.
>
> Hayes, by 'you' I meant Realtek, not you personally. If my
> reply seemed aggressive, I apologise.
>
> > [...]
> > > Below are the changes Debian currently applies in preparation for
> > > proper licencing of the firmware.
> >
> > Do you have some scripts to convert the data at hand ?
> [...]
>
> No, it's easy enough to convert a single array by copying it
> into a C file that dumps it to stdout (assuming the file's
> byte order is defined to match your own machine).
>
> It might be worth adding some sort of header with a version
> and checksum. Your choice, really.
>
> Ben.
>
> --
> Ben Hutchings, Debian Developer and kernel team member
>
>
next prev parent reply other threads:[~2010-11-29 3:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 11:54 Hayes Wang
2010-11-26 13:50 ` Ben Hutchings
2010-11-26 22:49 ` Francois Romieu
2010-11-26 23:12 ` Ben Hutchings
2010-11-29 3:47 ` hayeswang [this message]
2010-11-29 23:33 ` Francois Romieu
2010-11-30 0:13 ` Stephen Hemminger
2010-11-30 6:37 ` hayeswang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CE0F8B12F31D4E82860F4CE06907E98B@realtek.com.tw \
--to=hayeswang@realtek.com \
--cc=564628@bugs.debian.org \
--cc=benh@debian.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®