Re: [patch 2/9] perf: Use appropriate pointer type instead of silly typecasting

Re: [patch 2/9] perf: Use appropriate pointer type instead of silly typecasting

[Arnaldo Carvalho de Melo]

Em Tue, Nov 30, 2010 at 05:49:35PM -0000, Thomas Gleixner escreveu:
> There is no reason to use a struct sample_event pointer in struct sample_queue
> and type cast it when flushing the queue.
 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

I touched that code in a branch I'm working on, same change :-\ Well,
testing the other patches, thanks!

- Arnaldo

>  tools/perf/util/session.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6-tip/tools/perf/util/session.c
> ===================================================================
> --- linux-2.6-tip.orig/tools/perf/util/session.c
> +++ linux-2.6-tip/tools/perf/util/session.c
> @@ -386,7 +386,7 @@ static event__swap_op event__swap_ops[] 
>  
>  struct sample_queue {
>  	u64			timestamp;
> -	struct sample_event	*event;
> +	event_t			*event;
>  	struct list_head	list;
>  };
>  
> @@ -406,7 +406,7 @@ static void flush_sample_queue(struct pe
>  		if (iter->timestamp > limit)
>  			break;
>  
> -		ops->sample((event_t *)iter->event, s);
> +		ops->sample(iter->event, s);
>  
>  		os->last_flush = iter->timestamp;
>  		list_del(&iter->list);
> 

[tip:perf/core] perf session: Use appropriate pointer type instead of silly typecasting

[tip-bot for Thomas Gleixner]

Commit-ID:  28990f75e66b36faf6ce56747890009d4e250243
Gitweb:     http://git.kernel.org/tip/28990f75e66b36faf6ce56747890009d4e250243
Author:     Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Tue, 30 Nov 2010 17:49:35 +0000
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 30 Nov 2010 19:55:26 -0200

perf session: Use appropriate pointer type instead of silly typecasting

There is no reason to use a struct sample_event pointer in struct sample_queue
and type cast it when flushing the queue.

Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <20101130163819.969462809@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/session.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index daca557..525bcf6 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -386,7 +386,7 @@ static event__swap_op event__swap_ops[] = {
 
 struct sample_queue {
 	u64			timestamp;
-	struct sample_event	*event;
+	event_t			*event;
 	struct list_head	list;
 };
 
@@ -406,7 +406,7 @@ static void flush_sample_queue(struct perf_session *s,
 		if (iter->timestamp > limit)
 			break;
 
-		ops->sample((event_t *)iter->event, s);
+		ops->sample(iter->event, s);
 
 		os->last_flush = iter->timestamp;
 		list_del(&iter->list);