From: Randy Dunlap <rdunlap@xenotime.net>
To: Dave Airlie <airlied@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Julien Cristau <jcristau@debian.org>,
Alexander Shishkin <virtuoso@slind.org>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/4] drm: fix headers to include linux/types.h
Date: Wed, 1 Dec 2010 12:12:25 -0800 [thread overview]
Message-ID: <20101201121225.7a478a25.rdunlap@xenotime.net> (raw)
In-Reply-To: <AANLkTikYmVQ3A+DArFq+7z1MvhZDR6z+3-VdJpoRMV1K@mail.gmail.com>
On Thu, 2 Dec 2010 05:55:59 +1000 Dave Airlie wrote:
> On Thu, Dec 2, 2010 at 5:38 AM, Andrew Morton <akpm@linux-foundation.org> wrote:
> > On Wed, 1 Dec 2010 17:54:18 +0100
> > Julien Cristau <jcristau@debian.org> wrote:
> >
> >> On Wed, Dec 1, 2010 at 17:10:42 +0200, Alexander Shishkin wrote:
> >>
> >> > For headers that get exported to userland and make use of u32 style
> >> > type names, it is advised to include linux/types.h.
> >> >
> >> > This fixes 5 headers_check warnings.
> >> >
> >> How many times does this need to be NAKed?
> >
> > Until someone gets a clue and puts comments in there explaining this?
>
> how about someone fixing the dumb scripts to understand that C header
> includes aren't single level.
Still, drm is an exception here, so it needs to be documented as such.
> Like 10 people have posted this patch and not one has come back with a
> fix for the app after I pointed it out, like really if people think
> they can write C good enough to send kernel patches,
> maybe they could put some more effort in and actually fix a real problem.
>
> We should start hashing signed-off-by's so people can't get any glory from them.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-12-01 20:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 15:10 [PATCH 0/4] trivial header fixes Alexander Shishkin
2010-12-01 15:10 ` [PATCH 1/4] drm: fix headers to include linux/types.h Alexander Shishkin
2010-12-01 16:54 ` Julien Cristau
2010-12-01 17:37 ` Alexander Shishkin
2010-12-01 17:54 ` Kristian Høgsberg
2010-12-01 19:38 ` Andrew Morton
2010-12-01 19:55 ` [Intel-gfx] " Dave Airlie
2010-12-01 20:12 ` Randy Dunlap [this message]
2010-12-01 15:10 ` [PATCH 2/4] cramfs: hide function prototypes behind __KERNEL__ macro Alexander Shishkin
2010-12-01 15:10 ` [PATCH 3/4] scsi: fix a header to include linux/types.h Alexander Shishkin
2010-12-01 15:10 ` [PATCH 4/4] toshiba.h: hide a function prototypes behind __KERNEL__ macro Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201121225.7a478a25.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jcristau@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtuoso@slind.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®