From: Alexander Shishkin <virtuoso@slind.org>
To: Julien Cristau <jcristau@debian.org>
Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Alexander Shishkin <virtuoso@slind.org>
Subject: Re: [PATCH 1/4] drm: fix headers to include linux/types.h
Date: Wed, 1 Dec 2010 19:37:20 +0200 [thread overview]
Message-ID: <20101201173720.GL26184@shisha.kicks-ass.net> (raw)
In-Reply-To: <20101201165418.GU5063@radis.liafa.jussieu.fr>
On Wed, Dec 01, 2010 at 05:54:18PM +0100, Julien Cristau wrote:
> On Wed, Dec 1, 2010 at 17:10:42 +0200, Alexander Shishkin wrote:
>
> > For headers that get exported to userland and make use of u32 style
> > type names, it is advised to include linux/types.h.
> >
> > This fixes 5 headers_check warnings.
> >
> How many times does this need to be NAKed? These headers are shared
> with the BSDs, and they include drm.h which has the linux/types.h
> include on linux already.
One of the rules of including files that comes to mind is that one should
never rely on stuff being included from other headers but always explicitly
include those which are needed.
But if compatibility with other OS kernels is a valid reason to disregard
common coding practices, maybe at least it deserves a comment in those files?
But I really couldn't care less about these headers, so this is totally up
to you.
Regards,
--
Alex
next prev parent reply other threads:[~2010-12-01 17:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 15:10 [PATCH 0/4] trivial header fixes Alexander Shishkin
2010-12-01 15:10 ` [PATCH 1/4] drm: fix headers to include linux/types.h Alexander Shishkin
2010-12-01 16:54 ` Julien Cristau
2010-12-01 17:37 ` Alexander Shishkin [this message]
2010-12-01 17:54 ` Kristian Høgsberg
2010-12-01 19:38 ` Andrew Morton
2010-12-01 19:55 ` [Intel-gfx] " Dave Airlie
2010-12-01 20:12 ` Randy Dunlap
2010-12-01 15:10 ` [PATCH 2/4] cramfs: hide function prototypes behind __KERNEL__ macro Alexander Shishkin
2010-12-01 15:10 ` [PATCH 3/4] scsi: fix a header to include linux/types.h Alexander Shishkin
2010-12-01 15:10 ` [PATCH 4/4] toshiba.h: hide a function prototypes behind __KERNEL__ macro Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201173720.GL26184@shisha.kicks-ass.net \
--to=virtuoso@slind.org \
--cc=akpm@linux-foundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@suse.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jcristau@debian.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®