mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Alex Bennee <kernel-hacker@bennee.com>,
	Dave Hansen <dave@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] flex_array: export symbols to modules
Date: Thu, 2 Dec 2010 15:30:55 +0900	[thread overview]
Message-ID: <20101202063054.GB3367@linux-sh.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1012011714510.22420@chino.kir.corp.google.com>

On Wed, Dec 01, 2010 at 05:16:05PM -0800, David Rientjes wrote:
> On Wed, 1 Dec 2010, Alex Bennee wrote:
> > I want to be able to use the flex_array functions in my module so I
> > wanted to EXPORT_SYMBOL the API.
> > 
> > I added the appropriate EXPORT_SYMBOL runes into lib/flex_array.c and
> > added externs in the header files but after re-building there is still
> > no sign of them in Module.symvers.
> 
> You shouldn't need to add any externs in include/linux/flex_array.h, they 
> should already be publically declared.
> 
> Perhaps you forgot to include linux/module.h in lib/flex_array.c?
> 
> flex_array: export symbols to modules
> 
> Add EXPORT_SYMBOL() for all publically accessible flex array functions.
> 
> Cc: Dave Hansen <dave@linux.vnet.ibm.com>
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
>  lib/flex_array.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
This will be ineffective so long as flex_array.o remains lib-y. It will
need to be moved to obj-y if modules are to also make use of it.

  reply	other threads:[~2010-12-02  6:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-01 12:05 Problems using EXPORT_SYMBOL with lib/flex_array Alex Bennee
2010-12-01 13:20 ` Alex Bennee
2010-12-01 16:19   ` Américo Wang
2010-12-01 17:33     ` Alex Bennee
2010-12-02  1:16 ` [patch] flex_array: export symbols to modules David Rientjes
2010-12-02  6:30   ` Paul Mundt [this message]
2010-12-02  6:57     ` Américo Wang
2010-12-02  6:56       ` Paul Mundt
2010-12-02 23:44     ` [patch v2] " David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101202063054.GB3367@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=akpm@linux-foundation.org \
    --cc=dave@linux.vnet.ibm.com \
    --cc=kernel-hacker@bennee.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome