Re: [patch] flex_array: export symbols to modules

["Américo Wang" <xiyou.wangcong@gmail.com>]

On Thu, Dec 02, 2010 at 03:30:55PM +0900, Paul Mundt wrote:
>On Wed, Dec 01, 2010 at 05:16:05PM -0800, David Rientjes wrote:
>> On Wed, 1 Dec 2010, Alex Bennee wrote:
>> > I want to be able to use the flex_array functions in my module so I
>> > wanted to EXPORT_SYMBOL the API.
>> > 
>> > I added the appropriate EXPORT_SYMBOL runes into lib/flex_array.c and
>> > added externs in the header files but after re-building there is still
>> > no sign of them in Module.symvers.
>> 
>> You shouldn't need to add any externs in include/linux/flex_array.h, they 
>> should already be publically declared.
>> 
>> Perhaps you forgot to include linux/module.h in lib/flex_array.c?
>> 
>> flex_array: export symbols to modules
>> 
>> Add EXPORT_SYMBOL() for all publically accessible flex array functions.
>> 
>> Cc: Dave Hansen <dave@linux.vnet.ibm.com>
>> Signed-off-by: David Rientjes <rientjes@google.com>
>> ---
>>  lib/flex_array.c |   10 ++++++++++
>>  1 files changed, 10 insertions(+), 0 deletions(-)
>> 
>This will be ineffective so long as flex_array.o remains lib-y. It will
>need to be moved to obj-y if modules are to also make use of it.

Not moved, it needs to be added to obj-y.