From: Don Zickus <dzickus@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Vivek Goyal <vgoyal@redhat.com>, Yinghai Lu <yinghai@kernel.org>,
Ingo Molnar <mingo@elte.hu>,
Jason Wessel <jason.wessel@windriver.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Haren Myneni <hbabu@us.ibm.com>
Subject: Re: perf hw in kexeced kernel broken in tip
Date: Thu, 2 Dec 2010 11:15:02 -0500 [thread overview]
Message-ID: <20101202161502.GL18100@redhat.com> (raw)
In-Reply-To: <1291275270.4023.20.camel@twins>
On Thu, Dec 02, 2010 at 08:34:30AM +0100, Peter Zijlstra wrote:
> On Thu, 2010-12-02 at 00:23 -0500, Don Zickus wrote:
> > On Wed, Dec 01, 2010 at 01:48:07PM -0800, Eric W. Biederman wrote:
> > > >
> > > > Oh, but I'm not a device or sysdev thing, I'll never get something like
> > > > that.
> > >
> > > There is also the reboot notifier, if the NMI needs to be controlled
> > > outside of device model. Sigh. The NMI handling is such a special case.
> >
> > I tried reboot notifiers with the nmi_watchdog and acheived some success
> > (on a Westmere box, a P4 still failed). Kdump is still screwed, but maybe
> > we don't care for now.
> >
> > Here is the quick and dirty patch I used.
>
>
> We'd really want a perf_event.c callback there to do as the hot-unplug
> code does and detach all running counters from the cpu.
Ok, I moved the reboot notifier stuff from kernel/watchdog.c to
kernel/perf_event.c. Things still worked fine from a kexec perspective.
Vivek suggested to me this morning that I should just blantantly disable the
perf counter during init when running my test. Looking through the code I
don't think I can do this using disable_all because some routines look for
the active bit to be set and some arches have different disable registers
than others. Thoughts?
Cheers,
Don
next prev parent reply other threads:[~2010-12-02 16:15 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 8:00 Yinghai Lu
2010-12-01 11:27 ` Peter Zijlstra
2010-12-01 16:06 ` Vivek Goyal
2010-12-01 16:11 ` Peter Zijlstra
2010-12-01 16:23 ` Vivek Goyal
2010-12-01 19:38 ` Peter Zijlstra
2010-12-01 19:46 ` Vivek Goyal
2010-12-01 19:49 ` Peter Zijlstra
2010-12-01 19:58 ` Vivek Goyal
2010-12-01 20:07 ` Peter Zijlstra
2010-12-01 21:48 ` Eric W. Biederman
2010-12-02 5:23 ` Don Zickus
2010-12-02 7:34 ` Peter Zijlstra
2010-12-02 16:15 ` Don Zickus [this message]
2010-12-07 23:30 ` Peter Zijlstra
2010-12-08 14:01 ` Don Zickus
2010-12-08 14:20 ` Peter Zijlstra
2010-12-08 14:42 ` Vivek Goyal
2010-12-08 14:48 ` Peter Zijlstra
2010-12-08 15:02 ` Vivek Goyal
2010-12-08 15:15 ` Peter Zijlstra
2010-12-08 15:22 ` Vivek Goyal
2010-12-08 21:16 ` Eric W. Biederman
2010-12-08 14:59 ` Peter Zijlstra
2010-12-08 18:43 ` Yinghai Lu
2010-12-08 19:01 ` Don Zickus
2010-12-08 19:05 ` Yinghai Lu
2010-12-08 19:17 ` Peter Zijlstra
2010-12-08 19:20 ` Yinghai Lu
2010-12-08 19:06 ` Peter Zijlstra
2010-12-08 19:20 ` Yinghai Lu
2010-12-08 22:37 ` Don Zickus
2010-12-08 23:20 ` Eric W. Biederman
2010-12-09 4:34 ` Don Zickus
2010-12-09 20:20 ` Don Zickus
2010-12-09 20:44 ` Cyrill Gorcunov
2010-12-08 14:33 ` Peter Zijlstra
2010-12-08 14:39 ` Vivek Goyal
2010-12-07 21:16 ` Don Zickus
2010-12-08 0:26 ` Yinghai Lu
2010-12-08 10:39 ` Peter Zijlstra
2010-12-01 20:41 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101202161502.GL18100@redhat.com \
--to=dzickus@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hbabu@us.ibm.com \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=vgoyal@redhat.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome