* [PATCH] drivers/char/applicom.c: remove cvs ID and French in-file changelog
@ 2010-12-06 14:27 Uwe Kleine-König
2010-12-06 14:38 ` Alan Cox
0 siblings, 1 reply; 7+ messages in thread
From: Uwe Kleine-König @ 2010-12-06 14:27 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Morton
My script that finds typos always wants to do s/acces/access/ and
claims that "addresse" is wrong. While at it remove obsolete cvs id and
outdated reference to kernel version.
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/char/applicom.c | 18 ------------------
1 files changed, 0 insertions(+), 18 deletions(-)
diff --git a/drivers/char/applicom.c b/drivers/char/applicom.c
index 25373df..75c74cf 100644
--- a/drivers/char/applicom.c
+++ b/drivers/char/applicom.c
@@ -1,24 +1,6 @@
/* Derived from Applicom driver ac.c for SCO Unix */
/* Ported by David Woodhouse, Axiom (Cambridge) Ltd. */
/* dwmw2@infradead.org 30/8/98 */
-/* $Id: ac.c,v 1.30 2000/03/22 16:03:57 dwmw2 Exp $ */
-/* This module is for Linux 2.1 and 2.2 series kernels. */
-/*****************************************************************************/
-/* J PAGET 18/02/94 passage V2.4.2 ioctl avec code 2 reset to les interrupt */
-/* ceci pour reseter correctement apres une sortie sauvage */
-/* J PAGET 02/05/94 passage V2.4.3 dans le traitement de d'interruption, */
-/* LoopCount n'etait pas initialise a 0. */
-/* F LAFORSE 04/07/95 version V2.6.0 lecture bidon apres acces a une carte */
-/* pour liberer le bus */
-/* J.PAGET 19/11/95 version V2.6.1 Nombre, addresse,irq n'est plus configure */
-/* et passe en argument a acinit, mais est scrute sur le bus pour s'adapter */
-/* au nombre de cartes presentes sur le bus. IOCL code 6 affichait V2.4.3 */
-/* F.LAFORSE 28/11/95 creation de fichiers acXX.o avec les differentes */
-/* addresses de base des cartes, IOCTL 6 plus complet */
-/* J.PAGET le 19/08/96 copie de la version V2.6 en V2.8.0 sans modification */
-/* de code autre que le texte V2.6.1 en V2.8.0 */
-/*****************************************************************************/
-
#include <linux/kernel.h>
#include <linux/module.h>
--
1.7.2.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers/char/applicom.c: remove cvs ID and French in-file changelog
2010-12-06 14:27 [PATCH] drivers/char/applicom.c: remove cvs ID and French in-file changelog Uwe Kleine-König
@ 2010-12-06 14:38 ` Alan Cox
2010-12-06 14:46 ` Uwe Kleine-König
0 siblings, 1 reply; 7+ messages in thread
From: Alan Cox @ 2010-12-06 14:38 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-kernel, Andrew Morton
> claims that "addresse" is wrong. While at it remove obsolete cvs id and
> outdated reference to kernel version.
And removes a pair of authorship credits, which isn't allowed
(especially I'd note in France !)
I have no problem with moving the change data into the git log but I think
you should at least retain the names of the people who did the other work
in the header.
Alan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers/char/applicom.c: remove cvs ID and French in-file changelog
2010-12-06 14:38 ` Alan Cox
@ 2010-12-06 14:46 ` Uwe Kleine-König
2010-12-06 14:50 ` Alan Cox
0 siblings, 1 reply; 7+ messages in thread
From: Uwe Kleine-König @ 2010-12-06 14:46 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-kernel, Andrew Morton
Hello Alan,
On Mon, Dec 06, 2010 at 02:38:07PM +0000, Alan Cox wrote:
> > claims that "addresse" is wrong. While at it remove obsolete cvs id and
> > outdated reference to kernel version.
>
> And removes a pair of authorship credits, which isn't allowed
> (especially I'd note in France !)
>
> I have no problem with moving the change data into the git log but I think
> you should at least retain the names of the people who did the other work
> in the header.
Something like just adding
/* several changes by J. Paget and F. Laforse */
?
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers/char/applicom.c: remove cvs ID and French in-file changelog
2010-12-06 14:46 ` Uwe Kleine-König
@ 2010-12-06 14:50 ` Alan Cox
2010-12-06 15:19 ` Uwe Kleine-König
0 siblings, 1 reply; 7+ messages in thread
From: Alan Cox @ 2010-12-06 14:50 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-kernel, Andrew Morton
> Something like just adding
>
> /* several changes by J. Paget and F. Laforse */
Yeah
(if I read the french right - which is unlikely ;) then somthing like
/* Port to Linux 2.4 and 2.6 by ... */
but perhaps a French speaker can suggest the right wording to use)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers/char/applicom.c: remove cvs ID and French in-file changelog
2010-12-06 14:50 ` Alan Cox
@ 2010-12-06 15:19 ` Uwe Kleine-König
2011-04-06 14:45 ` Uwe Kleine-König
0 siblings, 1 reply; 7+ messages in thread
From: Uwe Kleine-König @ 2010-12-06 15:19 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-kernel, Andrew Morton
Hi Alan,
On Mon, Dec 06, 2010 at 02:50:28PM +0000, Alan Cox wrote:
> > Something like just adding
> >
> > /* several changes by J. Paget and F. Laforse */
>
> Yeah
>
> (if I read the french right - which is unlikely ;) then somthing like
>
> /* Port to Linux 2.4 and 2.6 by ... */
>
> but perhaps a French speaker can suggest the right wording to use)
My French is very limited, too, but I think the numbers don't have
anything to do with Linux version numbers. E.g. V2.6.0 is mentioned in
an entry dating 04/07/95 which is eight years before Linus released
2.6.0.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] drivers/char/applicom.c: remove cvs ID and French in-file changelog
2010-12-06 15:19 ` Uwe Kleine-König
@ 2011-04-06 14:45 ` Uwe Kleine-König
2011-08-15 11:00 ` Uwe Kleine-König
0 siblings, 1 reply; 7+ messages in thread
From: Uwe Kleine-König @ 2011-04-06 14:45 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Morton, Alan Cox, kernel
My script that finds typos always wants to do s/acces/access/ and
claims that "addresse" is wrong. While at it remove obsolete cvs id and
outdated reference to kernel version.
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/char/applicom.c | 19 +------------------
1 files changed, 1 insertions(+), 18 deletions(-)
diff --git a/drivers/char/applicom.c b/drivers/char/applicom.c
index 25373df..3e7af43 100644
--- a/drivers/char/applicom.c
+++ b/drivers/char/applicom.c
@@ -1,24 +1,7 @@
/* Derived from Applicom driver ac.c for SCO Unix */
/* Ported by David Woodhouse, Axiom (Cambridge) Ltd. */
/* dwmw2@infradead.org 30/8/98 */
-/* $Id: ac.c,v 1.30 2000/03/22 16:03:57 dwmw2 Exp $ */
-/* This module is for Linux 2.1 and 2.2 series kernels. */
-/*****************************************************************************/
-/* J PAGET 18/02/94 passage V2.4.2 ioctl avec code 2 reset to les interrupt */
-/* ceci pour reseter correctement apres une sortie sauvage */
-/* J PAGET 02/05/94 passage V2.4.3 dans le traitement de d'interruption, */
-/* LoopCount n'etait pas initialise a 0. */
-/* F LAFORSE 04/07/95 version V2.6.0 lecture bidon apres acces a une carte */
-/* pour liberer le bus */
-/* J.PAGET 19/11/95 version V2.6.1 Nombre, addresse,irq n'est plus configure */
-/* et passe en argument a acinit, mais est scrute sur le bus pour s'adapter */
-/* au nombre de cartes presentes sur le bus. IOCL code 6 affichait V2.4.3 */
-/* F.LAFORSE 28/11/95 creation de fichiers acXX.o avec les differentes */
-/* addresses de base des cartes, IOCTL 6 plus complet */
-/* J.PAGET le 19/08/96 copie de la version V2.6 en V2.8.0 sans modification */
-/* de code autre que le texte V2.6.1 en V2.8.0 */
-/*****************************************************************************/
-
+/* several changes by J. Paget and F. Laforse in 1994-1996 */
#include <linux/kernel.h>
#include <linux/module.h>
--
1.7.2.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers/char/applicom.c: remove cvs ID and French in-file changelog
2011-04-06 14:45 ` Uwe Kleine-König
@ 2011-08-15 11:00 ` Uwe Kleine-König
0 siblings, 0 replies; 7+ messages in thread
From: Uwe Kleine-König @ 2011-08-15 11:00 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Morton, Alan Cox, kernel, trivial, David Woodhouse
Hello,
On Wed, Apr 06, 2011 at 04:45:11PM +0200, Uwe Kleine-König wrote:
> My script that finds typos always wants to do s/acces/access/ and
> claims that "addresse" is wrong. While at it remove obsolete cvs id and
> outdated reference to kernel version.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/char/applicom.c | 19 +------------------
> 1 files changed, 1 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/char/applicom.c b/drivers/char/applicom.c
> index 25373df..3e7af43 100644
> --- a/drivers/char/applicom.c
> +++ b/drivers/char/applicom.c
> @@ -1,24 +1,7 @@
> /* Derived from Applicom driver ac.c for SCO Unix */
> /* Ported by David Woodhouse, Axiom (Cambridge) Ltd. */
> /* dwmw2@infradead.org 30/8/98 */
> -/* $Id: ac.c,v 1.30 2000/03/22 16:03:57 dwmw2 Exp $ */
> -/* This module is for Linux 2.1 and 2.2 series kernels. */
> -/*****************************************************************************/
> -/* J PAGET 18/02/94 passage V2.4.2 ioctl avec code 2 reset to les interrupt */
> -/* ceci pour reseter correctement apres une sortie sauvage */
> -/* J PAGET 02/05/94 passage V2.4.3 dans le traitement de d'interruption, */
> -/* LoopCount n'etait pas initialise a 0. */
> -/* F LAFORSE 04/07/95 version V2.6.0 lecture bidon apres acces a une carte */
> -/* pour liberer le bus */
> -/* J.PAGET 19/11/95 version V2.6.1 Nombre, addresse,irq n'est plus configure */
> -/* et passe en argument a acinit, mais est scrute sur le bus pour s'adapter */
> -/* au nombre de cartes presentes sur le bus. IOCL code 6 affichait V2.4.3 */
> -/* F.LAFORSE 28/11/95 creation de fichiers acXX.o avec les differentes */
> -/* addresses de base des cartes, IOCTL 6 plus complet */
> -/* J.PAGET le 19/08/96 copie de la version V2.6 en V2.8.0 sans modification */
> -/* de code autre que le texte V2.6.1 en V2.8.0 */
> -/*****************************************************************************/
> -
> +/* several changes by J. Paget and F. Laforse in 1994-1996 */
Is this material for trivial (added to Cc:)? Or should it go via akpm?
>
> #include <linux/kernel.h>
> #include <linux/module.h>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-08-15 11:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-06 14:27 [PATCH] drivers/char/applicom.c: remove cvs ID and French in-file changelog Uwe Kleine-König
2010-12-06 14:38 ` Alan Cox
2010-12-06 14:46 ` Uwe Kleine-König
2010-12-06 14:50 ` Alan Cox
2010-12-06 15:19 ` Uwe Kleine-König
2011-04-06 14:45 ` Uwe Kleine-König
2011-08-15 11:00 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®