From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI: Disable ASPM if BIOS asks us to
Date: Fri, 10 Dec 2010 21:18:49 +0000 [thread overview]
Message-ID: <20101210211849.GA16597@srcf.ucam.org> (raw)
In-Reply-To: <20101210130719.6ef6cd3d@jbarnes-desktop>
On Fri, Dec 10, 2010 at 01:07:19PM -0800, Jesse Barnes wrote:
> On Mon, 6 Dec 2010 14:00:56 -0500
> Matthew Garrett <mjg@redhat.com> wrote:
>
> > We currently refuse to touch the ASPM registers if the BIOS tells us that
> > ASPM isn't supported. This can cause problems if the BIOS has (for any
> > reason) enabled ASPM on some devices anyway. Change the code such that we
> > explicitly clear ASPM if the FADT indicates that ASPM isn't supported,
> > and make sure we tidy up appropriately on device removal in order to deal
> > with the hotplug case. If ASPM is disabled because the BIOS doesn't hand
> > over control then we won't touch the registers.
> >
> > Signed-off-by: Matthew Garrett <mjg@redhat.com>
> > ---
> >
>
> Applied to linux-next, thanks.
Agh. It seems I sent the wrong version - there's a missing e in
pci_clear_aspm. Can you fix that up, or should I resend?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-12-10 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 19:00 Matthew Garrett
2010-12-06 22:20 ` Rafael J. Wysocki
2010-12-10 21:07 ` Jesse Barnes
2010-12-10 21:18 ` Matthew Garrett [this message]
2010-12-10 21:21 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101210211849.GA16597@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®