From: HarryWei <harryxiyou@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: CodingStyle
Date: Sat, 11 Dec 2010 15:18:46 +0800 [thread overview]
Message-ID: <20101211071838.GA10959@gmail.com> (raw)
In-Reply-To: <90e6ba4fc2a4f7dd3c04971cb0fa@google.com>
> 2010/12/11 Robert P. J. Day <rpjday@crashcourse.ca>
>
> > On Sat, 11 Dec 2010, HarryWei wrote:
> >
> > > Hi all,
> > > I just read the CodingSyle at Documentation directory in
> > linux-2.6.23 kernel source code.
> > > But a problem happened to me like following.
> > > Functions in linux-2.6.23/fs/fs-writeback.c are "static int" and
> > function name are in different lines.(function name in following line)
> > > I can't find the rule in CodingStyle. That We often program
> > functions are "static int" and function name are in the same line.
> > > When do we do the first or second way? What is different between
> > them?
> > >
> > > Any answer is okay.
> > > Best regards.
> >
> > the advantage to the form
> >
> > static int
> > function-name
> >
> > is that, if you're looking for the actual function *definition* in the
> > file, having the function name at the start of a new line means you
> > can search for it with the pattern "^function-name" so that you don't
> > have to wade through all of the invocations of that function.
> >
> > i like that style; others claim that with proper cross-referencers
> > like cscope, doing that is redundant. as far as i know, the kernel
> > coding style doesn't take a position on that, but i'm willing to be
> > corrected.
Thanks, i see :)
> >
> > rday
> >
> > --
> >
> > ========================================================================
> > Robert P. J. Day Waterloo, Ontario, CANADA
> > http://crashcourse.ca
> >
> > Twitter: http://twitter.com/rpjday
> > LinkedIn: http://ca.linkedin.com/in/rpjday
> > ========================================================================
> >
>
>
>
> --
> Best Regards.
> Harry Wei.
> Do what u like!
next parent reply other threads:[~2010-12-11 7:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <90e6ba4fc2a4f7dd3c04971cb0fa@google.com>
2010-12-11 7:18 ` HarryWei [this message]
2013-04-18 10:48 CodingStyle Opensource [Anthony Olech]
2013-04-18 13:41 ` CodingStyle Guenter Roeck
2013-04-18 16:06 ` CodingStyle Opensource [Anthony Olech]
-- strict thread matches above, loose matches on Subject: below --
2006-08-31 12:37 sound/pci/hda/intel_hda: small cleanups Pavel Machek
2006-08-31 13:01 ` Takashi Iwai
2006-08-31 18:04 ` CodingStyle (was: Re: sound/pci/hda/intel_hda: small cleanups) Randy.Dunlap
2006-09-02 23:15 ` Pavel Machek
2006-09-03 4:30 ` Randy.Dunlap
2006-09-05 8:08 ` Pavel Machek
2006-09-05 16:40 ` CodingStyle Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101211071838.GA10959@gmail.com \
--to=harryxiyou@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome