mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: Takashi Iwai <tiwai@suse.de>, Andrew Morton <akpm@osdl.org>,
	kernel list <linux-kernel@vger.kernel.org>,
	perex@suse.cz, alsa-devel@alsa-project.org, pshou@realtek.com.tw
Subject: Re: CodingStyle (was: Re: sound/pci/hda/intel_hda: small cleanups)
Date: Sun, 3 Sep 2006 01:15:10 +0200	[thread overview]
Message-ID: <20060902231509.GC13031@elf.ucw.cz> (raw)
In-Reply-To: <20060831110436.995bdf93.rdunlap@xenotime.net>

Hi!

> > Hm, it looks rather like a personal preference.
> > IMHO, it's harder to read without space...
> 
> We have been tending toward not using space in cases like this
> (in my unscientific memory-based survey).
> 
> So, just this morning I have seen questions and opinions about
> the following that could (or could not) use more documentation
> or codification and I'm sure that we could easily find more,
> but do we want to codify Everything??
> 
> 
> 1.  Kconfig help text should be indented (it's not indented in the
> 	GFS2 patches)
> 
> 2.  if (!condition1)	/* no space between ! and condition1 */
> 
> 3.  don't use C99-style // comments
> 
> 4.  unsigned int bitfield :<nr_bits>;

Looks reasonable to me. Will you do the patch or should I ?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

-- 
VGER BF report: U 0.489855

  reply	other threads:[~2006-09-02 23:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-31 12:37 sound/pci/hda/intel_hda: small cleanups Pavel Machek
2006-08-31 13:01 ` Takashi Iwai
2006-08-31 13:39   ` Pavel Machek
2006-08-31 14:53     ` Takashi Iwai
2006-08-31 22:29       ` Pavel Machek
2006-08-31 18:04   ` CodingStyle (was: Re: sound/pci/hda/intel_hda: small cleanups) Randy.Dunlap
2006-09-02 23:15     ` Pavel Machek [this message]
2006-09-03  4:30       ` Randy.Dunlap
2006-09-05  8:08         ` Pavel Machek
2006-09-05 15:26           ` Takashi Iwai
2006-09-05 15:43           ` Randy.Dunlap
2006-09-06  7:23             ` Ingo Oeser
2006-09-06 13:51             ` Pavel Machek
2006-09-06 22:22               ` Chase Venters
2006-09-05 16:40           ` CodingStyle Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060902231509.GC13031@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=akpm@osdl.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    --cc=pshou@realtek.com.tw \
    --cc=rdunlap@xenotime.net \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome