From: Randy Dunlap <rdunlap@xenotime.net>
To: Jesper Juhl <jj@chaosbits.net>
Cc: Rakesh Iyer <riyer@nvidia.com>,
tsoni@codeaurora.org, shubhrajyoti@ti.com, ccross@android.com,
konkers@android.com, olof@lixom.net, achew@nvidia.com,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH v2] input: tegra-kbc - Add tegra keyboard driver
Date: Thu, 6 Jan 2011 14:27:14 -0800 [thread overview]
Message-ID: <20110106142714.f823dea8.rdunlap@xenotime.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1101062311340.13988@swampdragon.chaosbits.net>
On Thu, 6 Jan 2011 23:15:01 +0100 (CET) Jesper Juhl wrote:
> > +fail:
> > + if (kbc->irq >= 0)
> > + free_irq(kbc->irq, pdev);
> > + if (kbc->idev)
> > + input_free_device(kbc->idev);
>
> As far as I can tell input_free_device() deals gracefully with being
> passed a null pointer, so the 'if' seems superfluous.
>
>
> --
> Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
> Plain text mails only, please.
+ Please trim replies to the relevant part(s) of patches.
thnx,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-01-06 22:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 22:05 riyer
2011-01-06 22:15 ` Jesper Juhl
2011-01-06 22:27 ` Randy Dunlap [this message]
2011-01-07 2:49 ` Rakesh Iyer
2011-01-07 6:06 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106142714.f823dea8.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=achew@nvidia.com \
--cc=ccross@android.com \
--cc=jj@chaosbits.net \
--cc=konkers@android.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=riyer@nvidia.com \
--cc=shubhrajyoti@ti.com \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®