mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] FS-Cache: Fix operation handling
@ 2011-01-14 16:00 David Howells
  0 siblings, 0 replies; only message in thread
From: David Howells @ 2011-01-14 16:00 UTC (permalink / raw)
  To: torvalds, akpm; +Cc: linux-cachefs, linux-kernel, Akshat Aranya, David Howells

From: Akshat Aranya <aranya@nec-labs.com>

fscache_submit_exclusive_op() adds an operation to the pending list if
other operations are pending.  Fix the check for pending ops as n_ops must be
greater than 0 at the point it is checked as it is incremented immediately
before under lock.

Signed-off-by: Akshat Aranya <aranya@nec-labs.com>
Signed-off-by: David Howells <dhowells@redhat.com>
---

 fs/fscache/operation.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/fscache/operation.c b/fs/fscache/operation.c
index b9f34ea..48a18f1 100644
--- a/fs/fscache/operation.c
+++ b/fs/fscache/operation.c
@@ -101,7 +101,7 @@ int fscache_submit_exclusive_op(struct fscache_object *object,
 		object->n_ops++;
 		object->n_exclusive++;	/* reads and writes must wait */
 
-		if (object->n_ops > 0) {
+		if (object->n_ops > 1) {
 			atomic_inc(&op->usage);
 			list_add_tail(&op->pend_link, &object->pending_ops);
 			fscache_stat(&fscache_n_op_pend);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-01-14 16:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-14 16:00 [PATCH] FS-Cache: Fix operation handling David Howells

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®