[PATCH] staging/comedi/me4000: fix sparse warning "obsolete struct initializer"

[PATCH] staging/comedi/me4000: fix sparse warning "obsolete struct initializer"

[Peter Huewe]

This patch fixes the sparse warnings in me4000.c:
me4000.c:122:1: warning: obsolete struct initializer, use C99 syntax
me4000.c:123:1: warning: obsolete struct initializer, use C99 syntax
me4000.c:124:1: warning: obsolete struct initializer, use C99 syntax
me4000.c:125:1: warning: obsolete struct initializer, use C99 syntax
by converting the struct to use C99 syntax

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
 drivers/staging/comedi/drivers/me4000.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/comedi/drivers/me4000.c b/drivers/staging/comedi/drivers/me4000.c
index e6825c2..75511ba 100644
--- a/drivers/staging/comedi/drivers/me4000.c
+++ b/drivers/staging/comedi/drivers/me4000.c
@@ -119,10 +119,10 @@ static int me4000_attach(struct comedi_device *dev,
 			 struct comedi_devconfig *it);
 static int me4000_detach(struct comedi_device *dev);
 static struct comedi_driver driver_me4000 = {
-driver_name: "me4000",
-module : THIS_MODULE,
-attach : me4000_attach,
-detach : me4000_detach,
+	.driver_name = "me4000",
+	.module = THIS_MODULE,
+	.attach = me4000_attach,
+	.detach = me4000_detach,
 };
 
 /*-----------------------------------------------------------------------------
-- 
1.7.2.2

Re: [PATCH] staging/comedi/me4000: fix sparse warning "obsolete struct initializer"

[Peter Hüwe]

Am Montag 10 Januar 2011, 23:07:16 schrieb Peter Huewe:
> This patch fixes the sparse warnings in me4000.c:
> me4000.c:122:1: warning: obsolete struct initializer, use C99 syntax
> me4000.c:123:1: warning: obsolete struct initializer, use C99 syntax
> me4000.c:124:1: warning: obsolete struct initializer, use C99 syntax
> me4000.c:125:1: warning: obsolete struct initializer, use C99 syntax
> by converting the struct to use C99 syntax
> 
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
 Ping - any updates on this one?

Thanks,
Peter

Re: [PATCH] staging/comedi/me4000: fix sparse warning "obsolete struct initializer"

[Greg KH]

On Tue, Jan 18, 2011 at 10:49:10PM +0100, Peter Hüwe wrote:
> Am Montag 10 Januar 2011, 23:07:16 schrieb Peter Huewe:
> > This patch fixes the sparse warnings in me4000.c:
> > me4000.c:122:1: warning: obsolete struct initializer, use C99 syntax
> > me4000.c:123:1: warning: obsolete struct initializer, use C99 syntax
> > me4000.c:124:1: warning: obsolete struct initializer, use C99 syntax
> > me4000.c:125:1: warning: obsolete struct initializer, use C99 syntax
> > by converting the struct to use C99 syntax
> > 
> > Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
>  Ping - any updates on this one?

I have to wait until .38-rc1 before I can look at these.  Now that it is
out, I hope to get through my huge patch-queue by Friday, before I take
off on another trip...

Actually, that trip does provide a whole lot of uninterrupted plane
time, so that might be a bit better place to do this work...

thanks,

greg k-h