mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wu Fengguang <wfg@linux.intel.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH] sound, hda_eld: suspicious sizeof() in call to snd_print_pcm_bits()
Date: Sat, 29 Jan 2011 18:46:33 +0800	[thread overview]
Message-ID: <20110129104633.GA12643@localhost> (raw)
In-Reply-To: <alpine.LNX.2.00.1101290132560.6465@swampdragon.chaosbits.net>

On Sat, Jan 29, 2011 at 01:40:04AM +0100, Jesper Juhl wrote:

>  	if (a->format == AUDIO_CODING_TYPE_LPCM)
> -		snd_print_pcm_bits(a->sample_bits, buf2 + 8, sizeof(buf2 - 8));
> +		snd_print_pcm_bits(a->sample_bits, buf2 + 8, sizeof(buf2) - 8);

Good catch!

Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>

  reply	other threads:[~2011-01-29 10:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-29  0:40 Jesper Juhl
2011-01-29 10:46 ` Wu Fengguang [this message]
2011-01-29 11:01 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110129104633.GA12643@localhost \
    --to=wfg@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=jj@chaosbits.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®