mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Jaroslav Kysela <perex@perex.cz>,
	Wu Fengguang <wfg@linux.intel.com>
Subject: Re: [PATCH] sound, hda_eld: suspicious sizeof() in call to snd_print_pcm_bits()
Date: Sat, 29 Jan 2011 12:01:55 +0100	[thread overview]
Message-ID: <s5hpqrgas7w.wl%tiwai@suse.de> (raw)
In-Reply-To: <alpine.LNX.2.00.1101290132560.6465@swampdragon.chaosbits.net>

At Sat, 29 Jan 2011 01:40:04 +0100 (CET),
Jesper Juhl wrote:
> 
> In hdmi_show_short_audio_desc() we call snd_print_pcm_bits() like this:
>   snd_print_pcm_bits(a->sample_bits, buf2 + 8, sizeof(buf2 - 8));
> that last argument is supposed to be the size of the buffer that 
> snd_print_pcm_bits() writes to, so I believe it should be this:
>   snd_print_pcm_bits(a->sample_bits, buf2 + 8, sizeof(buf2) - 8);
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>

Thanks, but this was already fixed in sound git tree and included in
the pending pull request for 2.6.38.


Takashi

> ---
>  hda_eld.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>  Compile tested only. I don't have relevant hardware.
> 
> diff --git a/sound/pci/hda/hda_eld.c b/sound/pci/hda/hda_eld.c
> index 4a66347..74b0560 100644
> --- a/sound/pci/hda/hda_eld.c
> +++ b/sound/pci/hda/hda_eld.c
> @@ -381,7 +381,7 @@ static void hdmi_show_short_audio_desc(struct cea_sad *a)
>  	snd_print_pcm_rates(a->rates, buf, sizeof(buf));
>  
>  	if (a->format == AUDIO_CODING_TYPE_LPCM)
> -		snd_print_pcm_bits(a->sample_bits, buf2 + 8, sizeof(buf2 - 8));
> +		snd_print_pcm_bits(a->sample_bits, buf2 + 8, sizeof(buf2) - 8);
>  	else if (a->max_bitrate)
>  		snprintf(buf2, sizeof(buf2),
>  				", max bitrate = %d", a->max_bitrate);
> 
> 
> -- 
> Jesper Juhl <jj@chaosbits.net>            http://www.chaosbits.net/
> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
> Plain text mails only, please.
> 

      parent reply	other threads:[~2011-01-29 11:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-29  0:40 Jesper Juhl
2011-01-29 10:46 ` Wu Fengguang
2011-01-29 11:01 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hpqrgas7w.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=jj@chaosbits.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=wfg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®