From: Aristeu Rozanski <aris@cathedrallabs.org>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uinput strnlen bugfix
Date: Sun, 6 Feb 2011 11:55:24 -0500 [thread overview]
Message-ID: <20110206165524.GG22170@cathedrallabs.org> (raw)
In-Reply-To: <AANLkTi=vBv_a+X3MrgyDevss9H92vBJ51eON_qyMJW4=@mail.gmail.com>
On Sun, Feb 06, 2011 at 05:49:23PM +0100, David Herrmann wrote:
> The uinput device driver (drivers/input/misc/uinput.c) incorrectly
> computes the size of new device names. This patch fixes this. The diff
> is against 2.6.37 but the bug also exists in the most recent git
> sources.
>
> strnlen() never returns negative numbers so the result should be
> incremented after checking for zero. Otherwise the test will always be
> false. This bug allows empty input device names.
>
> Please CC me, I'm not subscribed to the mailing list.
and where's the patch? :^)
--
Aristeu
next prev parent reply other threads:[~2011-02-06 17:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 16:49 David Herrmann
2011-02-06 16:55 ` Aristeu Rozanski [this message]
2011-02-06 16:57 ` David Herrmann
2011-02-06 17:23 ` Aristeu Rozanski
2011-02-07 7:40 ` Dmitry Torokhov
2011-02-07 12:52 ` David Herrmann
2011-02-07 13:25 ` Aristeu Rozanski
2011-02-08 7:38 ` Dmitry Torokhov
2011-02-08 19:58 ` Aristeu Rozanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110206165524.GG22170@cathedrallabs.org \
--to=aris@cathedrallabs.org \
--cc=dh.herrmann@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®