From: Aristeu Rozanski <aris@cathedrallabs.org>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH] uinput strnlen bugfix
Date: Sun, 6 Feb 2011 12:23:17 -0500 [thread overview]
Message-ID: <20110206172317.GI22170@cathedrallabs.org> (raw)
In-Reply-To: <AANLkTimZq3-zuiA940dK7AmszBW-TEHP0JHz7FGHSmgu@mail.gmail.com>
On Sun, Feb 06, 2011 at 05:57:19PM +0100, David Herrmann wrote:
> On Sun, Feb 6, 2011 at 5:55 PM, Aristeu Rozanski <aris@cathedrallabs.org> wrote:
> > and where's the patch? :^)
> >
> > --
> > Aristeu
> >
>
> ah, embarrasing.., sorry.
> I attached the patchfile.
>
> David
> --- old/drivers/input/misc/uinput.c 2011-02-06 17:40:24.951454656 +0100
> +++ new/drivers/input/misc/uinput.c 2011-02-06 17:41:16.747454654 +0100
> @@ -372,8 +372,8 @@
>
> udev->ff_effects_max = user_dev->ff_effects_max;
>
> - size = strnlen(user_dev->name, UINPUT_MAX_NAME_SIZE) + 1;
> - if (!size) {
> + size = strnlen(user_dev->name, UINPUT_MAX_NAME_SIZE);
> + if (!size++) {
> retval = -EINVAL;
> goto exit;
> }
Acked-by: Aristeu Rozanski <aris@ruivo.org>
--
Aristeu
next prev parent reply other threads:[~2011-02-06 20:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 16:49 David Herrmann
2011-02-06 16:55 ` Aristeu Rozanski
2011-02-06 16:57 ` David Herrmann
2011-02-06 17:23 ` Aristeu Rozanski [this message]
2011-02-07 7:40 ` Dmitry Torokhov
2011-02-07 12:52 ` David Herrmann
2011-02-07 13:25 ` Aristeu Rozanski
2011-02-08 7:38 ` Dmitry Torokhov
2011-02-08 19:58 ` Aristeu Rozanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110206172317.GI22170@cathedrallabs.org \
--to=aris@cathedrallabs.org \
--cc=dh.herrmann@googlemail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®