* [PATCH] pch_can: fix tseg1/tseg2 setting issue
@ 2011-02-10 0:39 Tomoya MORINAGA
2011-02-10 0:46 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Tomoya MORINAGA @ 2011-02-10 0:39 UTC (permalink / raw)
To: wg, socketcan-core, netdev, linux-kernel
Cc: qi.wang, yong.y.wang, andrew.chih.howe.khor, joel.clark,
kok.howg.ewe, toshiharu-linux, Tomoya MORINAGA
Previous patch "[PATCH 1/3] pch_can: fix 800k comms issue" is wrong.
I should have modified tseg1_min not tseg2_min.
This patch reverts tseg2_min to 1 and set tseg1_min to 2.
Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
---
drivers/net/can/pch_can.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c
index 7d8bc12..e54712b 100644
--- a/drivers/net/can/pch_can.c
+++ b/drivers/net/can/pch_can.c
@@ -185,9 +185,9 @@ struct pch_can_priv {
static struct can_bittiming_const pch_can_bittiming_const = {
.name = KBUILD_MODNAME,
- .tseg1_min = 1,
+ .tseg1_min = 2,
.tseg1_max = 16,
- .tseg2_min = 2,
+ .tseg2_min = 1,
.tseg2_max = 8,
.sjw_max = 4,
.brp_min = 1,
--
1.7.3.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pch_can: fix tseg1/tseg2 setting issue
2011-02-10 0:39 [PATCH] pch_can: fix tseg1/tseg2 setting issue Tomoya MORINAGA
@ 2011-02-10 0:46 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-02-10 0:46 UTC (permalink / raw)
To: tomoya-linux
Cc: wg, socketcan-core, netdev, linux-kernel, qi.wang, yong.y.wang,
andrew.chih.howe.khor, joel.clark, kok.howg.ewe, toshiharu-linux
From: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Date: Thu, 10 Feb 2011 09:39:59 +0900
> Previous patch "[PATCH 1/3] pch_can: fix 800k comms issue" is wrong.
> I should have modified tseg1_min not tseg2_min.
> This patch reverts tseg2_min to 1 and set tseg1_min to 2.
>
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-10 0:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-10 0:39 [PATCH] pch_can: fix tseg1/tseg2 setting issue Tomoya MORINAGA
2011-02-10 0:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®