* [PATCH][trivial] Freescale STMP37XX/STMP378X Application UART driver: remove duplicate linux/device.h include
@ 2011-02-14 22:54 Jesper Juhl
2011-02-15 10:52 ` Jiri Kosina
2011-02-15 17:36 ` Sascha Hauer
0 siblings, 2 replies; 4+ messages in thread
From: Jesper Juhl @ 2011-02-14 22:54 UTC (permalink / raw)
To: linux-kernel; +Cc: Sascha Hauer, dmitry pervushin, trivial
Do not include linux/device.h twice in drivers/tty/serial/mxs-auart.c .
Once is enough.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
mxs-auart.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
index 6d01ac9..7e02c9c 100644
--- a/drivers/tty/serial/mxs-auart.c
+++ b/drivers/tty/serial/mxs-auart.c
@@ -15,7 +15,6 @@
*/
#include <linux/kernel.h>
-#include <linux/device.h>
#include <linux/errno.h>
#include <linux/init.h>
#include <linux/console.h>
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Plain text mails only, please.
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][trivial] Freescale STMP37XX/STMP378X Application UART driver: remove duplicate linux/device.h include
2011-02-14 22:54 [PATCH][trivial] Freescale STMP37XX/STMP378X Application UART driver: remove duplicate linux/device.h include Jesper Juhl
@ 2011-02-15 10:52 ` Jiri Kosina
2011-02-15 14:44 ` Jesper Juhl
2011-02-15 17:36 ` Sascha Hauer
1 sibling, 1 reply; 4+ messages in thread
From: Jiri Kosina @ 2011-02-15 10:52 UTC (permalink / raw)
To: Jesper Juhl; +Cc: linux-kernel, Sascha Hauer, dmitry pervushin
On Mon, 14 Feb 2011, Jesper Juhl wrote:
> Do not include linux/device.h twice in drivers/tty/serial/mxs-auart.c .
> Once is enough.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
> mxs-auart.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
> index 6d01ac9..7e02c9c 100644
> --- a/drivers/tty/serial/mxs-auart.c
> +++ b/drivers/tty/serial/mxs-auart.c
> @@ -15,7 +15,6 @@
> */
>
> #include <linux/kernel.h>
> -#include <linux/device.h>
> #include <linux/errno.h>
> #include <linux/init.h>
> #include <linux/console.h>
I don't see this file in Linus' tree as of now, so I guess this is -next
stuff. Though I will not be applying it, and will let Sascha/Dmitry to
take care of it.
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][trivial] Freescale STMP37XX/STMP378X Application UART driver: remove duplicate linux/device.h include
2011-02-15 10:52 ` Jiri Kosina
@ 2011-02-15 14:44 ` Jesper Juhl
0 siblings, 0 replies; 4+ messages in thread
From: Jesper Juhl @ 2011-02-15 14:44 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-kernel, Sascha Hauer, dmitry pervushin
On Tue, 15 Feb 2011, Jiri Kosina wrote:
> On Mon, 14 Feb 2011, Jesper Juhl wrote:
>
> > Do not include linux/device.h twice in drivers/tty/serial/mxs-auart.c .
> > Once is enough.
> >
> > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> > ---
> > mxs-auart.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
> > index 6d01ac9..7e02c9c 100644
> > --- a/drivers/tty/serial/mxs-auart.c
> > +++ b/drivers/tty/serial/mxs-auart.c
> > @@ -15,7 +15,6 @@
> > */
> >
> > #include <linux/kernel.h>
> > -#include <linux/device.h>
> > #include <linux/errno.h>
> > #include <linux/init.h>
> > #include <linux/console.h>
>
> I don't see this file in Linus' tree as of now, so I guess this is -next
> stuff. Though I will not be applying it, and will let Sascha/Dmitry to
> take care of it.
>
Correct. Patch is against linux-next.
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Plain text mails only, please.
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][trivial] Freescale STMP37XX/STMP378X Application UART driver: remove duplicate linux/device.h include
2011-02-14 22:54 [PATCH][trivial] Freescale STMP37XX/STMP378X Application UART driver: remove duplicate linux/device.h include Jesper Juhl
2011-02-15 10:52 ` Jiri Kosina
@ 2011-02-15 17:36 ` Sascha Hauer
1 sibling, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2011-02-15 17:36 UTC (permalink / raw)
To: Jesper Juhl; +Cc: linux-kernel, dmitry pervushin, trivial
On Mon, Feb 14, 2011 at 11:54:00PM +0100, Jesper Juhl wrote:
> Do not include linux/device.h twice in drivers/tty/serial/mxs-auart.c .
> Once is enough.
Applied. Should show up in -next tomorrow.
Sascha
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
> mxs-auart.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
> index 6d01ac9..7e02c9c 100644
> --- a/drivers/tty/serial/mxs-auart.c
> +++ b/drivers/tty/serial/mxs-auart.c
> @@ -15,7 +15,6 @@
> */
>
> #include <linux/kernel.h>
> -#include <linux/device.h>
> #include <linux/errno.h>
> #include <linux/init.h>
> #include <linux/console.h>
>
>
> --
> Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
> Plain text mails only, please.
> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-15 17:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-14 22:54 [PATCH][trivial] Freescale STMP37XX/STMP378X Application UART driver: remove duplicate linux/device.h include Jesper Juhl
2011-02-15 10:52 ` Jiri Kosina
2011-02-15 14:44 ` Jesper Juhl
2011-02-15 17:36 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®