From: Mike Travis <travis@sgi.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Len Brown <len.brown@intel.com>,
Yinghai Lu <yhlu.kernel@gmail.com>,
linux-acpi@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/5] x86: Minimize SRAT messages
Date: Thu, 17 Feb 2011 12:51:34 -0600 [thread overview]
Message-ID: <20110217185132.417819224@gulag1.americas.sgi.com> (raw)
In-Reply-To: <20110217185131.960038922@gulag1.americas.sgi.com>
[-- Attachment #1: minimize-srat-msgs.v2 --]
[-- Type: text/plain, Size: 2103 bytes --]
Condense the SRAT: messages to show all APIC id's for the
node on a single line.
v1: Added pertinent __init & __initdata specifiers.
v2: updated to apply to x86-tip
Signed-off-by: Mike Travis <travis@sgi.com>
Reviewed-by: Jack Steiner <steiner@sgi.com>
Reviewed-by: Robin Holt <holt@sgi.com>
---
arch/x86/mm/srat_64.c | 16 ++++++++++++----
drivers/acpi/numa.c | 3 +++
2 files changed, 15 insertions(+), 4 deletions(-)
--- linux.orig/arch/x86/mm/srat_64.c
+++ linux/arch/x86/mm/srat_64.c
@@ -116,6 +116,7 @@ acpi_numa_x2apic_affinity_init(struct ac
{
int pxm, node;
int apic_id;
+ static int __initdata last_node = -1, last_pxm = -1;
if (srat_disabled())
return;
@@ -141,8 +142,16 @@ acpi_numa_x2apic_affinity_init(struct ac
set_apicid_to_node(apic_id, node);
node_set(node, cpu_nodes_parsed);
acpi_numa = 1;
- printk(KERN_INFO "SRAT: PXM %u -> APIC 0x%04x -> Node %u\n",
- pxm, apic_id, node);
+ if (node != last_node) {
+ pr_info("SRAT: Node %u: PXM:APIC %u:%u",
+ node, pxm, apic_id);
+ last_node = node;
+ last_pxm = pxm;
+ } else if (pxm != last_pxm) {
+ pr_cont(" %u:%u", pxm, apic_id);
+ last_pxm = pxm;
+ } else
+ pr_cont(" :%u", apic_id);
}
/* Callback for Proximity Domain -> LAPIC mapping */
@@ -301,8 +310,7 @@ acpi_numa_memory_affinity_init(struct ac
nd->end = end;
}
- printk(KERN_INFO "SRAT: Node %u PXM %u %lx-%lx\n", node, pxm,
- start, end);
+ pr_info("SRAT: Node %u PXM %u %lx+%lx\n", node, pxm, start, end-start);
if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) {
update_nodes_add(node, start, end);
--- linux.orig/drivers/acpi/numa.c
+++ linux/drivers/acpi/numa.c
@@ -286,6 +286,9 @@ int __init acpi_numa_init(void)
if (!acpi_table_parse(ACPI_SIG_SRAT, acpi_parse_srat)) {
acpi_table_parse_srat(ACPI_SRAT_TYPE_X2APIC_CPU_AFFINITY,
acpi_parse_x2apic_affinity, 0);
+ /* insure trailing newline is output */
+ pr_cont("\n");
+
acpi_table_parse_srat(ACPI_SRAT_TYPE_CPU_AFFINITY,
acpi_parse_processor_affinity, 0);
ret = acpi_table_parse_srat(ACPI_SRAT_TYPE_MEMORY_AFFINITY,
--
next prev parent reply other threads:[~2011-02-17 18:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 18:51 [PATCH 0/5] init: Shrink early messages to prevent overflowing the kernel log buffer Mike Travis
2011-02-17 18:51 ` [PATCH 1/5] ACPI: Minimize X2APIC initial messages Mike Travis
2011-02-18 7:28 ` Ingo Molnar
2011-02-17 18:51 ` [PATCH 2/5] x86: Minimize initial e820 messages Mike Travis
2011-02-18 7:30 ` Ingo Molnar
2011-02-17 18:51 ` Mike Travis [this message]
2011-02-18 7:32 ` [PATCH 3/5] x86: Minimize SRAT messages Ingo Molnar
2011-02-17 18:51 ` [PATCH 4/5] printk: Minimize time zero output Mike Travis
2011-02-18 7:34 ` Ingo Molnar
2011-02-17 18:51 ` [PATCH 5/5] printk: Allocate kernel log buffer earlier Mike Travis
2011-02-17 23:21 ` Yinghai Lu
2011-02-17 23:52 ` Mike Travis
2011-02-18 7:40 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217185132.417819224@gulag1.americas.sgi.com \
--to=travis@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®