mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH]Add a condition for CodingStyle
@ 2011-02-19 15:43 Harry Wei
  0 siblings, 0 replies; only message in thread
From: Harry Wei @ 2011-02-19 15:43 UTC (permalink / raw)
  To: rdunlap, greg, torvalds, akpm, linux-kernel; +Cc: linux-doc

Hi us,
     When i see Documentation/CodingStyle, i find a missing case for "Chapter 3: Placing Braces and Spaces". We often know we should not use braces where a single statement. The first case is:
	if (condition)
		action();
Another case is:
	if (condition)
		do_this();
	else
		do_that();

     However, i can not find the second case. So i patch like following.

     Thanks.
     Best Regards.
     Harry Wei.

Signed-off-by: Harry Wei <harryxiyou@gmail.com>
---
 Documentation/CodingStyle |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
index 8bb3723..37eac37 100644
--- a/Documentation/CodingStyle
+++ b/Documentation/CodingStyle
@@ -168,6 +168,13 @@ Do not unnecessarily use braces where a single statement will do.
 if (condition)
 	action();
 
+and
+
+if (condition)
+	do_this();
+else
+	do_that();
+
 This does not apply if one branch of a conditional statement is a single
 statement. Use braces in both branches.
 
-- 
1.7.0.4


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-02-19 15:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-19 15:43 [PATCH]Add a condition for CodingStyle Harry Wei

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome