Undefined TASK_INTERRUPTIBLE (Was: Re: [PATCH 1/3] iwlwifi: move rx handlers code to iwl-rx.c)

Undefined TASK_INTERRUPTIBLE (Was: Re: [PATCH 1/3] iwlwifi: move rx handlers code to iwl-rx.c)

[Stanislaw Gruszka]

On Sun, Mar 06, 2011 at 03:47:55PM -0800, Daniel Halperin wrote:
> This fixes the error for me.

Code compile on 64 bits, but fail on 32, hmm ...

> Dan
> 
> index 7dc2d39..e3ba4d5 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-rx.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-rx.c
> @@ -30,6 +30,7 @@
>  #include <linux/etherdevice.h>
>  #include <linux/slab.h>
>  #include <net/mac80211.h>
> +#include <linux/sched.h>
>  #include <asm/unaligned.h>
>  #include "iwl-eeprom.h"
>  #include "iwl-dev.h"

This fixes the problem, I will post signed-off patch to John in
a second.

But perhaps we need a more generic fix in wait.h for the future. Maybe
we should decouple definitions of TASK_INTERRUPTIBLE and friends from
sched.h into separate header and include that header in wait.h as well?

Stanislaw

> On Sun, Mar 6, 2011 at 1:34 PM, Guy, Wey-Yi <wey-yi.w.guy@intel.com> wrote:
> > Hi Stanislaw,
> >
> > On Fri, 2011-03-04 at 08:51 -0800, Stanislaw Gruszka wrote:
> >> Put generic rx_handlers (except iwlagn_rx_reply_compressed_ba) to
> >> iwl-rx.c . Make functions static and change prefix from iwlagn_ to
> >> iwl_ . Beautify iwl_setup_rx_handlers and do some other minor coding
> >> style changes.
> >>
> >> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> >> ---
> > this patch break the compiling
> >
> > drivers/net/wireless/iwlwifi/iwl-rx.c:778:17: error: undefined
> > identifier 'TASK_INTERRUPTIBLE'
> >  CC [M]  drivers/net/wireless/iwlwifi/iwl-rx.o
> > drivers/net/wireless/iwlwifi/iwl-rx.c: In function
> > ‘iwl_rx_card_state_notif’:
> > drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: ‘TASK_INTERRUPTIBLE’
> > undeclared (first use in this function)
> > drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: (Each undeclared
> > identifier is reported only once
> > drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: for each function it
> > appears in.)
> > make[1]: *** [drivers/net/wireless/iwlwifi/iwl-rx.o] Error 1
> > make: *** [_module_drivers/net/wireless/iwlwifi] Error 2
> >
> >
> > Thanks
> > Wey
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >

Re: Undefined TASK_INTERRUPTIBLE (Was: Re: [PATCH 1/3] iwlwifi: move rx handlers code to iwl-rx.c)

[Peter Zijlstra]

On Mon, 2011-03-07 at 09:12 +0100, Stanislaw Gruszka wrote:
> 
> But perhaps we need a more generic fix in wait.h for the future. Maybe
> we should decouple definitions of TASK_INTERRUPTIBLE and friends from
> sched.h into separate header and include that header in wait.h as
> well?

No! That only makes the mess worse, the only sane option is to fix
things so that wait.h can include sched.h and that is non-trivial.

Re: Undefined TASK_INTERRUPTIBLE (Was: Re: [PATCH 1/3] iwlwifi: move rx handlers code to iwl-rx.c)

[Stanislaw Gruszka]

On Mon, Mar 07, 2011 at 10:20:02AM +0100, Peter Zijlstra wrote:
> On Mon, 2011-03-07 at 09:12 +0100, Stanislaw Gruszka wrote:
> > 
> > But perhaps we need a more generic fix in wait.h for the future. Maybe
> > we should decouple definitions of TASK_INTERRUPTIBLE and friends from
> > sched.h into separate header and include that header in wait.h as
> > well?
> 
> No! That only makes the mess worse, the only sane option is to fix
> things so that wait.h can include sched.h and that is non-trivial.

I was not aware of recent discussion
http://marc.info/?t=129829886000004&r=1&w=2