From: Grant Likely <grant.likely@secretlab.ca>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Miguel Gaio <miguel.gaio@efixo.com>,
Mocean Laboratories <info@mocean-labs.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] gpio: Use __devexit at necessary places
Date: Sat, 12 Mar 2011 02:14:37 -0700 [thread overview]
Message-ID: <20110312091437.GI9347@angua.secretlab.ca> (raw)
In-Reply-To: <1299748245.18619.5.camel@mola>
On Thu, Mar 10, 2011 at 05:10:45PM +0800, Axel Lin wrote:
> The function gen_74x164_remove and mc33880_remove are used only wrapped
> by __devexit_p so define it using __devexit.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Cc: Miguel Gaio <miguel.gaio@efixo.com>
> Cc: Mocean Laboratories <info@mocean-labs.com>
Applied, thanks.
g.
> ---
> drivers/gpio/74x164.c | 2 +-
> drivers/gpio/mc33880.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/74x164.c b/drivers/gpio/74x164.c
> index d91ff4c..84e0702 100644
> --- a/drivers/gpio/74x164.c
> +++ b/drivers/gpio/74x164.c
> @@ -133,7 +133,7 @@ exit_destroy:
> return ret;
> }
>
> -static int gen_74x164_remove(struct spi_device *spi)
> +static int __devexit gen_74x164_remove(struct spi_device *spi)
> {
> struct gen_74x164_chip *chip;
> int ret;
> diff --git a/drivers/gpio/mc33880.c b/drivers/gpio/mc33880.c
> index 935479d..00f6d24 100644
> --- a/drivers/gpio/mc33880.c
> +++ b/drivers/gpio/mc33880.c
> @@ -146,7 +146,7 @@ exit_destroy:
> return ret;
> }
>
> -static int mc33880_remove(struct spi_device *spi)
> +static int __devexit mc33880_remove(struct spi_device *spi)
> {
> struct mc33880 *mc;
> int ret;
> --
> 1.7.2
>
>
>
prev parent reply other threads:[~2011-03-12 9:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 9:10 Axel Lin
2011-03-12 9:14 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110312091437.GI9347@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=akpm@linux-foundation.org \
--cc=axel.lin@gmail.com \
--cc=info@mocean-labs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.gaio@efixo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®