mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] gpio: Use  __devexit at necessary places
@ 2011-03-10  9:10 Axel Lin
  2011-03-12  9:14 ` Grant Likely
  0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2011-03-10  9:10 UTC (permalink / raw)
  To: linux-kernel
  Cc: Miguel Gaio, Mocean Laboratories, Grant Likely, Andrew Morton

The function gen_74x164_remove and mc33880_remove are used only wrapped
by __devexit_p so define it using __devexit.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Cc: Miguel Gaio <miguel.gaio@efixo.com>
Cc: Mocean Laboratories <info@mocean-labs.com>
---
 drivers/gpio/74x164.c  |    2 +-
 drivers/gpio/mc33880.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/74x164.c b/drivers/gpio/74x164.c
index d91ff4c..84e0702 100644
--- a/drivers/gpio/74x164.c
+++ b/drivers/gpio/74x164.c
@@ -133,7 +133,7 @@ exit_destroy:
 	return ret;
 }
 
-static int gen_74x164_remove(struct spi_device *spi)
+static int __devexit gen_74x164_remove(struct spi_device *spi)
 {
 	struct gen_74x164_chip *chip;
 	int ret;
diff --git a/drivers/gpio/mc33880.c b/drivers/gpio/mc33880.c
index 935479d..00f6d24 100644
--- a/drivers/gpio/mc33880.c
+++ b/drivers/gpio/mc33880.c
@@ -146,7 +146,7 @@ exit_destroy:
 	return ret;
 }
 
-static int mc33880_remove(struct spi_device *spi)
+static int __devexit mc33880_remove(struct spi_device *spi)
 {
 	struct mc33880 *mc;
 	int ret;
-- 
1.7.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] gpio: Use  __devexit at necessary places
  2011-03-10  9:10 [PATCH] gpio: Use __devexit at necessary places Axel Lin
@ 2011-03-12  9:14 ` Grant Likely
  0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2011-03-12  9:14 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Miguel Gaio, Mocean Laboratories, Andrew Morton

On Thu, Mar 10, 2011 at 05:10:45PM +0800, Axel Lin wrote:
> The function gen_74x164_remove and mc33880_remove are used only wrapped
> by __devexit_p so define it using __devexit.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Cc: Miguel Gaio <miguel.gaio@efixo.com>
> Cc: Mocean Laboratories <info@mocean-labs.com>

Applied, thanks.

g.

> ---
>  drivers/gpio/74x164.c  |    2 +-
>  drivers/gpio/mc33880.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/74x164.c b/drivers/gpio/74x164.c
> index d91ff4c..84e0702 100644
> --- a/drivers/gpio/74x164.c
> +++ b/drivers/gpio/74x164.c
> @@ -133,7 +133,7 @@ exit_destroy:
>  	return ret;
>  }
>  
> -static int gen_74x164_remove(struct spi_device *spi)
> +static int __devexit gen_74x164_remove(struct spi_device *spi)
>  {
>  	struct gen_74x164_chip *chip;
>  	int ret;
> diff --git a/drivers/gpio/mc33880.c b/drivers/gpio/mc33880.c
> index 935479d..00f6d24 100644
> --- a/drivers/gpio/mc33880.c
> +++ b/drivers/gpio/mc33880.c
> @@ -146,7 +146,7 @@ exit_destroy:
>  	return ret;
>  }
>  
> -static int mc33880_remove(struct spi_device *spi)
> +static int __devexit mc33880_remove(struct spi_device *spi)
>  {
>  	struct mc33880 *mc;
>  	int ret;
> -- 
> 1.7.2
> 
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-03-12  9:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-10  9:10 [PATCH] gpio: Use __devexit at necessary places Axel Lin
2011-03-12  9:14 ` Grant Likely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®