Re: [PATCH 1/2] hid-ntrig: sysfs nodes for modes

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Fri, Mar 11, 2011 at 04:56:45AM -0500, Rafi Rubin wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> User desires aren't exactly my specialty.  I just know the ntrig windows control
> panel gives the user that control with cute little radio buttons.
> 
> Would it be cleaner to expose the control with an ioctrl or some other mechanism?
> 
> I do have user space tools for mode and calibration, but that requires unbinding
> the device, and just seems sloppier.  But if this really is inappropriate to add
> the sysfs nodes, at least there's still some solution.

No, this is not inappropriate, I was just musing how useful they are. Do
we foresee users really using them or if is it more "we export because we can".
I.e. in which cases the default mode is not suitable?

> 
> Since you brought it up, I am thinking of removing some of the other nodes soon.
>  I've learned the physical and logical ranges are already exposed both through
> the event nodes and debugfs.  Also, I have better filtering that so far seems
> not to need as many parameters so I should be able to remove those nodes as well.
>

Well, that's the issue with sysfs - it really forms kernel ABI so
removing something that was once added is hard.

Thanks.

-- 
Dmitry