From: Rafi Rubin <rafi@seas.upenn.edu>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: jkosina@suse.cz, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, micki@n-trig.com,
rydberg@euromail.se, chatty@enac.fr
Subject: Re: [PATCH 1/2] hid-ntrig: sysfs nodes for modes
Date: Fri, 11 Mar 2011 04:56:45 -0500 [thread overview]
Message-ID: <4D79F1DD.10009@seas.upenn.edu> (raw)
In-Reply-To: <20110311081843.GE10807@core.coreip.homeip.net>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
User desires aren't exactly my specialty. I just know the ntrig windows control
panel gives the user that control with cute little radio buttons.
Would it be cleaner to expose the control with an ioctrl or some other mechanism?
I do have user space tools for mode and calibration, but that requires unbinding
the device, and just seems sloppier. But if this really is inappropriate to add
the sysfs nodes, at least there's still some solution.
Since you brought it up, I am thinking of removing some of the other nodes soon.
I've learned the physical and logical ranges are already exposed both through
the event nodes and debugfs. Also, I have better filtering that so far seems
not to need as many parameters so I should be able to remove those nodes as well.
Still learning,
Rafi
On 03/11/11 03:18, Dmitry Torokhov wrote:
> On Fri, Mar 11, 2011 at 02:37:51AM -0500, Rafi Rubin wrote:
>> Signed-off-by: Rafi Rubin <rafi@seas.upenn.edu>
>>
>> ---
>>
>> If the code is there, might as well expose a friendly interface to the
>> user.
>
> The bigger question is should the user care? If we can make the device
> work well without user intervention then we should not really expose
> extra attributes.
>
> Thanks.
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJNefHZAAoJEPILXytRLnK2ud4QAJxzSX+tIrkZawpqvJM69mf3
1P4+E8vCXqsX9usaayGQoa/+CLe2so6frQo3B5nH8ExTOs8+a/Zx1Y9JbNxwqDBJ
aMeWBhO9stqdGjg2hllFeJNV/vuvlU7y6oOW6qme/sKHp0zfisco2nJNvG3yHAQl
tD0TVgiCeEIWkN/AAqoUxGSMtv9pOmkcVfShDVktmOH6pqAsacP29UENZBAKuqQ6
jHtJ2hfQV5NBrKjlHPhcvTiBRrls5SZ+RfRq4hy8MWC8Vj5rjjNLCxmgBeI5Ktqf
ZTRNVvvHClgIbuwHx5LdzPBFNjYv35A87vW8zMHb6/qU57KkeXL1VX6RcONTOS+w
6fWX2AYVMxs/6rU6nXfa/DxgRlPZqyVGP1E8VZ+bl09fJ41WR7xpsOIko93KemUq
DC+kxp9nyfH7bZEpWsr3chEQkbj2aT+1Rjc6312Vsio2Gbzgth8t0WWxEIX69Sp+
hZCzrFPFKiUrlWOdKQG1TkJNh6Z9a1HQLYb67ga2/liyJt9rW6uUfylQDJqN9adj
iGE9xVX6D4+da0CW+hl+0U+EhGX+ZSmvI5IgVdBGsxZnFa/ReP5nJKGFcJmkTtPO
WcZe0zqxORua6xPqA9p2cScbcvCXiHLQtjpLxBQMLlMgghKunSVX9Hl/3OrtOHRZ
r36BGVFmHWBvddvosBqK
=vHok
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-03-11 9:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 7:37 Rafi Rubin
2011-03-11 7:37 ` [PATCH 2/2] hid-ntrig: calibration Rafi Rubin
2011-03-21 17:15 ` Henrik Rydberg
2011-03-21 18:25 ` Rafi Rubin
2011-03-24 14:32 ` Jiri Kosina
2011-03-24 16:52 ` Rafi Rubin
2011-03-11 8:18 ` [PATCH 1/2] hid-ntrig: sysfs nodes for modes Dmitry Torokhov
2011-03-11 9:56 ` Rafi Rubin [this message]
2011-03-13 6:27 ` Dmitry Torokhov
2011-03-15 4:30 ` Rafi Rubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D79F1DD.10009@seas.upenn.edu \
--to=rafi@seas.upenn.edu \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micki@n-trig.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®