mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Waychison <mikew@google.com>
To: Greg KH <greg@kroah.com>, Matt Domsch <Matt_Domsch@dell.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Duncan Laurie <dlaurie@google.com>,
	Aaron Durbin <adurbin@google.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	Tim Hockin <thockin@google.com>, San Mehat <san@google.com>
Subject: [PATCH v3 2/5] x86: Better comments for get_bios_ebda()
Date: Mon, 14 Mar 2011 23:58:50 -0700	[thread overview]
Message-ID: <20110315065850.12047.76166.stgit@mike.mtv.corp.google.com> (raw)
In-Reply-To: <20110315065839.12047.70666.stgit@mike.mtv.corp.google.com>

Make the comments a bit clearer for get_bios_ebda so that it actually
tells us what it is returning.

Signed-off-by: Mike Waychison <mikew@google.com>
---
 arch/x86/include/asm/bios_ebda.h |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/bios_ebda.h b/arch/x86/include/asm/bios_ebda.h
index 5174cf0..aa6a317 100644
--- a/arch/x86/include/asm/bios_ebda.h
+++ b/arch/x86/include/asm/bios_ebda.h
@@ -4,11 +4,14 @@
 #include <asm/io.h>
 
 /*
- * there is a real-mode segmented pointer pointing to the
- * 4K EBDA area at 0x40E.
+ * Returns physical address of EBDA.  Returns 0 if there is no EBDA.
  */
 static inline unsigned int get_bios_ebda(void)
 {
+	/*
+	 * There is a real-mode segmented pointer pointing to the
+	 * 4K EBDA area at 0x40E.
+	 */
 	unsigned int address = *(unsigned short *)phys_to_virt(0x40E);
 	address <<= 4;
 	return address;	/* 0 means none */


  parent reply	other threads:[~2011-03-15  6:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-15  6:58 [PATCH v3 0/5] google firmware support Mike Waychison
2011-03-15  6:58 ` [PATCH v3 1/5] x86: get_bios_ebda_length() Mike Waychison
2011-04-19 23:50   ` Greg KH
2011-04-29 20:42   ` Greg KH
2011-03-15  6:58 ` Mike Waychison [this message]
2011-03-15  6:58 ` [PATCH v3 3/5] Introduce CONFIG_GOOGLE_FIRMWARE Mike Waychison
2011-04-29 21:23   ` Greg KH
2011-04-29 22:55     ` [PATCH v4 1/3] driver: Google EFI SMI Mike Waychison
2011-04-29 23:40       ` Greg KH
2011-04-30  0:14         ` Mike Waychison
2011-04-30  0:39         ` [PATCH v5 " Mike Waychison
2011-04-30  0:39         ` [PATCH v5 2/3] driver: Google Memory Console Mike Waychison
2011-04-30  0:39         ` [PATCH v5 3/3] Introduce CONFIG_GOOGLE_FIRMWARE Mike Waychison
2011-04-29 23:47       ` [PATCH v4 1/3] driver: Google EFI SMI Randy Dunlap
2011-04-29 23:59         ` Mike Waychison
2011-04-29 22:55     ` [PATCH v4 2/3] driver: Google Memory Console Mike Waychison
2011-04-29 22:56     ` [PATCH v4 3/3] Introduce CONFIG_GOOGLE_FIRMWARE Mike Waychison
2011-04-30 10:25       ` Alan Cox
2011-03-15  6:59 ` [PATCH v3 4/5] driver: Google EFI SMI Mike Waychison
2011-03-15  6:59 ` [PATCH v3 5/5] driver: Google Memory Console Mike Waychison
2011-03-15  7:13   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110315065850.12047.76166.stgit@mike.mtv.corp.google.com \
    --to=mikew@google.com \
    --cc=Matt_Domsch@dell.com \
    --cc=adurbin@google.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dlaurie@google.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=san@google.com \
    --cc=thockin@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome