mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Waychison <mikew@google.com>
To: Greg KH <greg@kroah.com>, Matt Domsch <Matt_Domsch@dell.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Duncan Laurie <dlaurie@google.com>,
	Aaron Durbin <adurbin@google.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	Tim Hockin <thockin@google.com>, San Mehat <san@google.com>
Subject: [PATCH v4 3/3] Introduce CONFIG_GOOGLE_FIRMWARE
Date: Fri, 29 Apr 2011 15:56:02 -0700	[thread overview]
Message-ID: <20110429225601.22013.92629.stgit@mike.mtv.corp.google.com> (raw)
In-Reply-To: <20110429212328.GA19207@kroah.com>

In order to keep Google's firmware drivers organized amongst themselves,
all Google firmware drivers are gated on CONFIG_GOOGLE_FIRMWARE=y, which
defaults to 'n' in the kernel build.

Signed-off-by: Mike Waychison <mikew@google.com>

---
Changelog:
v4:
   - Moved to end of series.
v3:
   - Removed comment about 'other implementations' in Kconfig message as
     per gregkh.
---
 drivers/firmware/Makefile       |    2 +-
 drivers/firmware/google/Kconfig |   14 ++++++++++++++
 2 files changed, 15 insertions(+), 1 deletions(-)

diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile
index 9fcf3b2..5a7e273 100644
--- a/drivers/firmware/Makefile
+++ b/drivers/firmware/Makefile
@@ -13,4 +13,4 @@ obj-$(CONFIG_ISCSI_IBFT_FIND)	+= iscsi_ibft_find.o
 obj-$(CONFIG_ISCSI_IBFT)	+= iscsi_ibft.o
 obj-$(CONFIG_FIRMWARE_MEMMAP)	+= memmap.o
 
-obj-y  += google/
+obj-$(CONFIG_GOOGLE_FIRMWARE)	+= google/
diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
index 640dc6b..87096b6 100644
--- a/drivers/firmware/google/Kconfig
+++ b/drivers/firmware/google/Kconfig
@@ -1,3 +1,15 @@
+config GOOGLE_FIRMWARE
+	bool "Google Firmware Drivers"
+	depends on X86
+	default n
+	help
+	  These firmware drivers are used by Google's servers.  They are
+	  only useful if you are working directly on one of their
+	  proprietary servers.  If in doubt, say "N".
+
+menu "Google Firmware Drivers"
+	depends on GOOGLE_FIRMWARE
+
 config GOOGLE_SMI
 	tristate "SMI interface for Google platforms"
 	depends on ACPI && DMI
@@ -15,3 +27,5 @@ config GOOGLE_MEMCONSOLE
 	  This option enables the kernel to search for a firmware log in
 	  the EBDA on Google servers.  If found, this log is exported to
 	  userland in the file /sys/firmware/log.
+
+endmenu


  parent reply	other threads:[~2011-04-29 22:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-15  6:58 [PATCH v3 0/5] google firmware support Mike Waychison
2011-03-15  6:58 ` [PATCH v3 1/5] x86: get_bios_ebda_length() Mike Waychison
2011-04-19 23:50   ` Greg KH
2011-04-29 20:42   ` Greg KH
2011-03-15  6:58 ` [PATCH v3 2/5] x86: Better comments for get_bios_ebda() Mike Waychison
2011-03-15  6:58 ` [PATCH v3 3/5] Introduce CONFIG_GOOGLE_FIRMWARE Mike Waychison
2011-04-29 21:23   ` Greg KH
2011-04-29 22:55     ` [PATCH v4 1/3] driver: Google EFI SMI Mike Waychison
2011-04-29 23:40       ` Greg KH
2011-04-30  0:14         ` Mike Waychison
2011-04-30  0:39         ` [PATCH v5 " Mike Waychison
2011-04-30  0:39         ` [PATCH v5 2/3] driver: Google Memory Console Mike Waychison
2011-04-30  0:39         ` [PATCH v5 3/3] Introduce CONFIG_GOOGLE_FIRMWARE Mike Waychison
2011-04-29 23:47       ` [PATCH v4 1/3] driver: Google EFI SMI Randy Dunlap
2011-04-29 23:59         ` Mike Waychison
2011-04-29 22:55     ` [PATCH v4 2/3] driver: Google Memory Console Mike Waychison
2011-04-29 22:56     ` Mike Waychison [this message]
2011-04-30 10:25       ` [PATCH v4 3/3] Introduce CONFIG_GOOGLE_FIRMWARE Alan Cox
2011-03-15  6:59 ` [PATCH v3 4/5] driver: Google EFI SMI Mike Waychison
2011-03-15  6:59 ` [PATCH v3 5/5] driver: Google Memory Console Mike Waychison
2011-03-15  7:13   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110429225601.22013.92629.stgit@mike.mtv.corp.google.com \
    --to=mikew@google.com \
    --cc=Matt_Domsch@dell.com \
    --cc=adurbin@google.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dlaurie@google.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=san@google.com \
    --cc=thockin@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome