From: Randy Dunlap <randy.dunlap@oracle.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
"linux-kernel" <linux-kernel@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@suse.de>
Subject: Re: [BUG] usb_wwan: build error
Date: Thu, 17 Mar 2011 10:07:18 -0700 [thread overview]
Message-ID: <20110317100718.6f4d6fe3.randy.dunlap@oracle.com> (raw)
In-Reply-To: <201103170702.28752.oliver@neukum.org>
On Thu, 17 Mar 2011 07:02:28 +0100 Oliver Neukum wrote:
> Am Donnerstag, 17. März 2011, 06:51:40 schrieb Eric Dumazet:
> > commit 16871dcac74c (usb_wwan: error case of resume) added a build error
> > if CONFIG_PM_RUNTIME is not defined.
> >
> > CC [M] drivers/usb/serial/usb_wwan.o
> > drivers/usb/serial/usb_wwan.c: In function ‘play_delayed’:
> > drivers/usb/serial/usb_wwan.c:702: error: ‘struct dev_pm_info’ has no
> > member named ‘usage_count’
> >
> > I suspect we should use pm_runtime_put_noidle() instead
>
> Yes. I don't understand why it compiled for me. Has it been removed?
usage_count is only there when CONFIG_PM_RUNTIME is enabled.
Building with CONFIG_PM_RUNTIME disabled produces a build error.
> Regards
> Oliver
>
> PS: patch about to follow
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
prev parent reply other threads:[~2011-03-17 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 5:51 Eric Dumazet
2011-03-17 6:02 ` Oliver Neukum
2011-03-17 17:07 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110317100718.6f4d6fe3.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=eric.dumazet@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome