* [BUG] usb_wwan: build error
@ 2011-03-17 5:51 Eric Dumazet
2011-03-17 6:02 ` Oliver Neukum
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2011-03-17 5:51 UTC (permalink / raw)
To: Oliver Neukum; +Cc: linux-kernel, Greg Kroah-Hartman
commit 16871dcac74c (usb_wwan: error case of resume) added a build error
if CONFIG_PM_RUNTIME is not defined.
CC [M] drivers/usb/serial/usb_wwan.o
drivers/usb/serial/usb_wwan.c: In function ‘play_delayed’:
drivers/usb/serial/usb_wwan.c:702: error: ‘struct dev_pm_info’ has no
member named ‘usage_count’
I suspect we should use pm_runtime_put_noidle() instead
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
drivers/usb/serial/usb_wwan.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c
index a65ddd5..916405c 100644
--- a/drivers/usb/serial/usb_wwan.c
+++ b/drivers/usb/serial/usb_wwan.c
@@ -698,8 +698,7 @@ static void play_delayed(struct usb_serial_port *port)
/* we have to throw away the rest */
do {
unbusy_queued_urb(urb, portdata);
- //extremely dirty
- atomic_dec(&port->serial->interface->dev.power.usage_count);
+ pm_runtime_put_noidle(&port->serial->interface->dev);
} while ((urb = usb_get_from_anchor(&portdata->delayed)));
break;
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [BUG] usb_wwan: build error
2011-03-17 5:51 [BUG] usb_wwan: build error Eric Dumazet
@ 2011-03-17 6:02 ` Oliver Neukum
2011-03-17 17:07 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Oliver Neukum @ 2011-03-17 6:02 UTC (permalink / raw)
To: Eric Dumazet; +Cc: linux-kernel, Greg Kroah-Hartman
Am Donnerstag, 17. März 2011, 06:51:40 schrieb Eric Dumazet:
> commit 16871dcac74c (usb_wwan: error case of resume) added a build error
> if CONFIG_PM_RUNTIME is not defined.
>
> CC [M] drivers/usb/serial/usb_wwan.o
> drivers/usb/serial/usb_wwan.c: In function ‘play_delayed’:
> drivers/usb/serial/usb_wwan.c:702: error: ‘struct dev_pm_info’ has no
> member named ‘usage_count’
>
> I suspect we should use pm_runtime_put_noidle() instead
Yes. I don't understand why it compiled for me. Has it been removed?
Regards
Oliver
PS: patch about to follow
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BUG] usb_wwan: build error
2011-03-17 6:02 ` Oliver Neukum
@ 2011-03-17 17:07 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2011-03-17 17:07 UTC (permalink / raw)
To: Oliver Neukum; +Cc: Eric Dumazet, linux-kernel, Greg Kroah-Hartman
On Thu, 17 Mar 2011 07:02:28 +0100 Oliver Neukum wrote:
> Am Donnerstag, 17. März 2011, 06:51:40 schrieb Eric Dumazet:
> > commit 16871dcac74c (usb_wwan: error case of resume) added a build error
> > if CONFIG_PM_RUNTIME is not defined.
> >
> > CC [M] drivers/usb/serial/usb_wwan.o
> > drivers/usb/serial/usb_wwan.c: In function ‘play_delayed’:
> > drivers/usb/serial/usb_wwan.c:702: error: ‘struct dev_pm_info’ has no
> > member named ‘usage_count’
> >
> > I suspect we should use pm_runtime_put_noidle() instead
>
> Yes. I don't understand why it compiled for me. Has it been removed?
usage_count is only there when CONFIG_PM_RUNTIME is enabled.
Building with CONFIG_PM_RUNTIME disabled produces a build error.
> Regards
> Oliver
>
> PS: patch about to follow
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-17 17:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-17 5:51 [BUG] usb_wwan: build error Eric Dumazet
2011-03-17 6:02 ` Oliver Neukum
2011-03-17 17:07 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome