From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org, dzickus@redhat.com
Subject: Re: [PATCH]: SMBIOS: Add initial code and export version via sysfs
Date: Thu, 17 Mar 2011 19:09:32 +0000 [thread overview]
Message-ID: <20110317190932.074949b4@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20110317135754.25241.88177.sendpatchset@prarit.bos.redhat.com>
> +static struct class smbios_class = {
> + .name = "smbios",
> + .dev_release = (void(*)(struct device *)) kfree,
> +};
I thought the policy was no new classes- Greg ?
> + smbios_iounmap(buf, sizeof(*smbios_step));
> + printk(KERN_INFO "SMBIOS: Invalid STEP table checksum = %u\n",
> + chksum1);
Surely this isn't INFO ?
next prev parent reply other threads:[~2011-03-17 19:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 13:57 Prarit Bhargava
2011-03-17 19:09 ` Alan Cox [this message]
2011-03-17 19:12 ` Prarit Bhargava
2011-03-17 19:22 ` Greg KH
2011-03-17 19:30 ` Greg KH
2011-03-17 19:55 ` Prarit Bhargava
2011-03-17 20:07 ` Greg KH
2011-03-21 15:45 ` Prarit Bhargava
2011-03-21 16:06 ` Alan Cox
2011-03-27 22:29 ` Prarit Bhargava
2011-03-17 20:08 ` Prarit Bhargava
2011-03-17 20:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110317190932.074949b4@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=dzickus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®