* [PATCH 1/1] cciss: fix lost command issue
@ 2011-03-23 19:33 Mike Miller
0 siblings, 0 replies; only message in thread
From: Mike Miller @ 2011-03-23 19:33 UTC (permalink / raw)
To: Andrew Morton, Jens Axboe
Cc: LKML, LKML-scsi, bud.brown, mike.bacco, Tom Coughlan, alan.ross
Patch 1 of 1
cciss: fix lost command problem
From: Bud Brown <bud.brown@redhat.com>
Under certain workloads a command may seem to get lost. IOW, the Smart Array
thinks all commands have been completed but we still have commands in our
completion queue. This may lead to system instability, filesystems going
read-only, or even panics depending on the affected filesystem. We add an
extra read to force the write to complete.
Testing shows this extra read avoids the problem.
Signed-off-by: Mike Miller <mike.miller@hp.com>
diff -urNp linux-2.6/drivers/block/cciss.h linux-2.6-03212011/drivers/block/cciss.h
--- linux-2.6/drivers/block/cciss.h 2011-03-21 15:41:23.100192400 -0500
+++ linux-2.6-03212011/drivers/block/cciss.h 2011-03-21 15:39:20.472192814 -0500
@@ -222,6 +222,7 @@ static void SA5_submit_command( ctlr_inf
h->ctlr, c->busaddr);
#endif /* CCISS_DEBUG */
writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
+ readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
h->commands_outstanding++;
if ( h->commands_outstanding > h->max_outstanding)
h->max_outstanding = h->commands_outstanding;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-03-23 19:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-23 19:33 [PATCH 1/1] cciss: fix lost command issue Mike Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®