mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Lin Ming <ming.m.lin@intel.com>, Don Zickus <dzickus@redhat.com>,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] perf, x86: P4 PMU - Add missing read of a counter before test
Date: Thu, 24 Mar 2011 17:51:42 +0100	[thread overview]
Message-ID: <20110324165142.GB2414@elte.hu> (raw)
In-Reply-To: <4D8B7570.40101@gmail.com>


* Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> Unflagged overflows never have been catched due to missed read of a register which
> is to signalize about it, and as result unknown nmi may happen leading to
> "Dazen and confused" message. That is what supposed to be in changelog?

Exactly, the 'Dazed and confused' message is *all* that the user cares about so 
it must feature prominently in the changelog.

If a P4 user searches lkml he wants to know which fixed address 
dazed-and-confused messages. He will know nothing about 'unflagged overflows' 
or other internals ...

All the other details about how the patch does the fix is secondary to what 
users experience when they hit this bug.

Thanks,

	Ingo

  parent reply	other threads:[~2011-03-24 16:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-24  8:29 Cyrill Gorcunov
2011-03-24  8:48 ` Ingo Molnar
2011-03-24  9:33   ` Cyrill Gorcunov
2011-03-24 15:38   ` Cyrill Gorcunov
2011-03-24 16:33     ` Ingo Molnar
2011-03-24 16:46       ` Cyrill Gorcunov
2011-03-24 16:47         ` Cyrill Gorcunov
2011-03-24 16:51         ` Ingo Molnar [this message]
2011-03-24 17:06           ` Cyrill Gorcunov
2011-03-24 18:22         ` Don Zickus
2011-03-24 18:26           ` Cyrill Gorcunov
2011-03-24 20:03             ` Ingo Molnar
2011-03-24 12:28 ` Don Zickus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110324165142.GB2414@elte.hu \
    --to=mingo@elte.hu \
    --cc=dzickus@redhat.com \
    --cc=gorcunov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®