mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Seth Forshee <seth.forshee@canonical.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Corentin Chary <corentin.chary@gmail.com>,
	Chris Bagwell <chris@cnpbagwell.com>,
	Matthew Garrett <mjg@redhat.com>,
	acpi4asus-user@lists.sourceforge.net,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, vojtech@suze.cz
Subject: Re: [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key
Date: Fri, 25 Mar 2011 13:58:24 -0500	[thread overview]
Message-ID: <20110325185824.GE14328@thinkpad-t410> (raw)
In-Reply-To: <20110325170333.GD5099@core.coreip.homeip.net>

On Fri, Mar 25, 2011 at 10:03:33AM -0700, Dmitry Torokhov wrote:
> > So, would the following make sense (KEY_TBD is may abbreviation for "key
> > to be determinded"):
> > 
> >  - On press (0xe4), send KEY_TBD, value = 1
> >  - On hold (0xea), send KEY_TBD, value = 2
> >  - On release (0xe5), send KEY_TBD, value = 0
> 
> Yes.

There's a little problem with this. The driver uses sparse-keymap, which
calls input_report_key(), which is doing this:

	input_event(dev, EV_KEY, code, !!value);

I don't see the hold events in userspace, so they must be getting
dropped as duplicates as you suggested.

I'm not sure who is at fault here. Should input_report_key() not be
forcing value to 0 or 1? Or should sparse-keymap be calling
input_event() directly? Or is sparse-keymap the wrong tool for handling
keys this way?

Thanks,
Seth


  reply	other threads:[~2011-03-25 18:58 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-23 19:39 [PATCH] eeepc-wmi: Add support for T101MT "Express Gate" key Seth Forshee
2011-03-24  7:33 ` Corentin Chary
2011-03-24 13:14   ` Seth Forshee
2011-03-24 13:26     ` Corentin Chary
2011-03-24 13:27     ` Chris Bagwell
2011-03-24 13:32       ` Chris Bagwell
2011-03-24 13:37       ` Seth Forshee
2011-03-24 13:40       ` Corentin Chary
2011-03-24 14:00         ` Chris Bagwell
2011-03-24 19:57           ` Seth Forshee
2011-03-24 20:03             ` [PATCH 1/2] asus-wmi: Add callback for hotkey filtering Seth Forshee
2011-03-24 20:03             ` [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key Seth Forshee
2011-03-24 20:09               ` Seth Forshee
2011-03-25 13:28               ` Corentin Chary
2011-03-25 13:53                 ` Seth Forshee
2011-03-25 14:05                   ` Corentin Chary
2011-03-25 14:53                     ` Chris Bagwell
2011-03-25 15:13                       ` Seth Forshee
2011-03-25 15:43                       ` Corentin Chary
2011-03-25 16:17                         ` Seth Forshee
2011-03-25 16:14                     ` Dmitry Torokhov
2011-03-25 16:28                       ` Seth Forshee
2011-03-25 17:03                         ` Dmitry Torokhov
2011-03-25 18:58                           ` Seth Forshee [this message]
2011-03-27 17:13                             ` Dmitry Torokhov
2011-03-27 18:32                               ` Chris Bagwell
2011-03-27 19:11                                 ` Dmitry Torokhov
2011-03-28 13:46                                   ` Seth Forshee
2011-03-28 14:14                                     ` Corentin Chary
2011-03-28 18:33                                       ` Seth Forshee
2011-03-28 18:33                                         ` [PATCH v3 1/3] asus-wmi: Add callback for hotkey filtering Seth Forshee
2011-03-28 18:33                                         ` [PATCH v3 2/3] eeepc-wmi: Add support for T101MT Home/Express Gate key Seth Forshee
2011-03-29 12:29                                           ` Corentin Chary
2011-03-29 13:42                                             ` Seth Forshee
2011-03-29 13:47                                             ` Matthew Garrett
2011-03-30  7:46                                               ` Corentin Chary
2011-03-28 18:33                                         ` [PATCH v3 3/3] asus-wmi: Enable autorepeat for hotkey input device Seth Forshee
2011-03-29  6:33                                         ` [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key Dmitry Torokhov
2011-03-25 16:07           ` [PATCH] eeepc-wmi: Add support for T101MT "Express Gate" key Dmitry Torokhov
2011-03-25 16:08             ` Corentin Chary
2011-03-25 16:05       ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110325185824.GE14328@thinkpad-t410 \
    --to=seth.forshee@canonical.com \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=chris@cnpbagwell.com \
    --cc=corentin.chary@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=vojtech@suze.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome