mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: Corentin Chary <corentin.chary@gmail.com>,
	Chris Bagwell <chris@cnpbagwell.com>,
	Matthew Garrett <mjg@redhat.com>,
	acpi4asus-user@lists.sourceforge.net,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key
Date: Mon, 28 Mar 2011 23:33:41 -0700	[thread overview]
Message-ID: <20110329063341.GA26490@core.coreip.homeip.net> (raw)
In-Reply-To: <1301337224-3293-1-git-send-email-seth.forshee@canonical.com>

On Mon, Mar 28, 2011 at 01:33:41PM -0500, Seth Forshee wrote:
> On Mon, Mar 28, 2011 at 02:14:33PM +0000, Corentin Chary wrote:
> > But since Dmitry and Chris seems to prefer the autorepeat approach
> > with a single key code, if it works then it's ok, we just need to set
> > REP_DELAY, report press and release events, and drop 0xea events.
> 
> New patches follow. I didn't set REP_DELAY (or REP_PERIOD) because the
> input core interprets this to mean that the driver will handle the
> autorepeat itself. There's always EVIOCSREP to change the delay and
> repeat period from userspace.

Just an FYI: it is perfectly fine to set custom REP_DELAY and REP_PERIOD
after registering an input device.

Thanks.

-- 
Dmitry

  parent reply	other threads:[~2011-03-29  6:33 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-23 19:39 [PATCH] eeepc-wmi: Add support for T101MT "Express Gate" key Seth Forshee
2011-03-24  7:33 ` Corentin Chary
2011-03-24 13:14   ` Seth Forshee
2011-03-24 13:26     ` Corentin Chary
2011-03-24 13:27     ` Chris Bagwell
2011-03-24 13:32       ` Chris Bagwell
2011-03-24 13:37       ` Seth Forshee
2011-03-24 13:40       ` Corentin Chary
2011-03-24 14:00         ` Chris Bagwell
2011-03-24 19:57           ` Seth Forshee
2011-03-24 20:03             ` [PATCH 1/2] asus-wmi: Add callback for hotkey filtering Seth Forshee
2011-03-24 20:03             ` [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key Seth Forshee
2011-03-24 20:09               ` Seth Forshee
2011-03-25 13:28               ` Corentin Chary
2011-03-25 13:53                 ` Seth Forshee
2011-03-25 14:05                   ` Corentin Chary
2011-03-25 14:53                     ` Chris Bagwell
2011-03-25 15:13                       ` Seth Forshee
2011-03-25 15:43                       ` Corentin Chary
2011-03-25 16:17                         ` Seth Forshee
2011-03-25 16:14                     ` Dmitry Torokhov
2011-03-25 16:28                       ` Seth Forshee
2011-03-25 17:03                         ` Dmitry Torokhov
2011-03-25 18:58                           ` Seth Forshee
2011-03-27 17:13                             ` Dmitry Torokhov
2011-03-27 18:32                               ` Chris Bagwell
2011-03-27 19:11                                 ` Dmitry Torokhov
2011-03-28 13:46                                   ` Seth Forshee
2011-03-28 14:14                                     ` Corentin Chary
2011-03-28 18:33                                       ` Seth Forshee
2011-03-28 18:33                                         ` [PATCH v3 1/3] asus-wmi: Add callback for hotkey filtering Seth Forshee
2011-03-28 18:33                                         ` [PATCH v3 2/3] eeepc-wmi: Add support for T101MT Home/Express Gate key Seth Forshee
2011-03-29 12:29                                           ` Corentin Chary
2011-03-29 13:42                                             ` Seth Forshee
2011-03-29 13:47                                             ` Matthew Garrett
2011-03-30  7:46                                               ` Corentin Chary
2011-03-28 18:33                                         ` [PATCH v3 3/3] asus-wmi: Enable autorepeat for hotkey input device Seth Forshee
2011-03-29  6:33                                         ` Dmitry Torokhov [this message]
2011-03-25 16:07           ` [PATCH] eeepc-wmi: Add support for T101MT "Express Gate" key Dmitry Torokhov
2011-03-25 16:08             ` Corentin Chary
2011-03-25 16:05       ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110329063341.GA26490@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=chris@cnpbagwell.com \
    --cc=corentin.chary@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=seth.forshee@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome