mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: trenn@novell.com, suresh.b.siddha@intel.com
Cc: linux-kernel@vger.kernel.org
Subject: stop_con_cpu_nowait() usage in set_mtrr()
Date: Tue, 29 Mar 2011 15:08:55 +0200	[thread overview]
Message-ID: <20110329130855.GA16492@htj.dyndns.org> (raw)

Hello, Suresh, Thomas.

This is about the openSUSE complete system freeze at start bug Thomas
just pinged about - https://bugzilla.novell.com/show_bug.cgi?id=672008

I looked through the set_mtrr() code and it's implementing its own
stop_machine() using stop_one_cpu_nowait().  This isn't safe.  There
is only one stop cpu execution context per cpu and the custom
implementation can race against the standard stop_machine() - it can
deadlock with each holding some of the execution contexts and neither
stepping away.

Suresh, is there any reason why set_mtrr() is using its own
synchronization instead of stop_machine()?

Thanks.

-- 
tejun

                 reply	other threads:[~2011-03-29 13:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110329130855.GA16492@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=trenn@novell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®