* stop_con_cpu_nowait() usage in set_mtrr()
@ 2011-03-29 13:08 Tejun Heo
0 siblings, 0 replies; only message in thread
From: Tejun Heo @ 2011-03-29 13:08 UTC (permalink / raw)
To: trenn, suresh.b.siddha; +Cc: linux-kernel
Hello, Suresh, Thomas.
This is about the openSUSE complete system freeze at start bug Thomas
just pinged about - https://bugzilla.novell.com/show_bug.cgi?id=672008
I looked through the set_mtrr() code and it's implementing its own
stop_machine() using stop_one_cpu_nowait(). This isn't safe. There
is only one stop cpu execution context per cpu and the custom
implementation can race against the standard stop_machine() - it can
deadlock with each holding some of the execution contexts and neither
stepping away.
Suresh, is there any reason why set_mtrr() is using its own
synchronization instead of stop_machine()?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-03-29 13:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-29 13:08 stop_con_cpu_nowait() usage in set_mtrr() Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®