From: Matt Helsley <matthltc@us.ibm.com>
To: Nathan Lynch <ntl@pobox.com>
Cc: Oren Laadan <orenl@cs.columbia.edu>,
containers@lists.linux-foundation.org,
Alexey Dobriyan <adobriyan@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/10] Core checkpoint/restart support code
Date: Mon, 4 Apr 2011 15:29:14 -0700 [thread overview]
Message-ID: <20110404222914.GB27628@count0.beaverton.ibm.com> (raw)
In-Reply-To: <1301953409.31531.130.camel@tp-t61>
On Mon, Apr 04, 2011 at 04:43:29PM -0500, Nathan Lynch wrote:
> On Mon, 2011-04-04 at 13:32 -0400, Oren Laadan wrote:
> > From the technical point of view it *is* a big problem: there are
> > very good reasons why we chose a certain design.
> >
> > If Natahan is suggesting in-kernel tree creation as a temporary thing
> > to simplify the code for review - then, given that this patch handles
> > a single process, doing so add lots of unnecessary code, all of which
> > in the kernel.
> >
> > If this is the beginning of a permanent approach, then it is totally
> > incompatible with what we have done so far, and severely restricts
> > the kind of use--cases of the project, potentially making it too
> > unattractive for many natural adaptors, like HPC users. Sorry, nack.
>
> It's not a stopgap measure to "ease review" or whatever; recreating the
> task tree in-kernel is a fundamental - and simplifying - part of the
> design. I have earned through painful experience the opinion that
> recreating the task tree in userspace is pretty much insane, as is
> exposing the pid allocator to userspace via eclone(2), as is attempting
> to support c/r of any resource that isn't isolated/virtualized, as is
> having every recreated task "rendezvous" in the kernel by having them
> all call restart(2), even though little significant work can be done in
> parallel.
So far we've been proceeding under the assumption that some userspace
code ugliness was acceptable if it simplified the kernel code. With
ghost issues and the stuff you've mentioned above I think it's become
questionable whether that choice has simplified the kernel code enough
and trying something different is valuable.
At this point the only advantage I still see in userspace task creation for
restart is the reviewability of it. eclone is a small piece of code that
can be reviewed independently of restart and thus will prove alot easier to
review for correctness and security than in-kernel task creation for restart.
Cheers,
-Matt Helsley
next prev parent reply other threads:[~2011-04-04 22:36 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 23:40 [RFC 00/10] container-based checkpoint/restart prototype ntl
2011-02-28 23:40 ` [PATCH 01/10] Make exec_mmap extern ntl
2011-04-03 16:56 ` Serge E. Hallyn
2011-02-28 23:40 ` [PATCH 02/10] Introduce mm_has_pending_aio() helper ntl
2011-03-01 15:40 ` Jeff Moyer
2011-03-01 16:04 ` Nathan Lynch
2011-02-28 23:40 ` [PATCH 03/10] Introduce has_locks_with_owner() helper ntl
2011-04-03 18:55 ` Serge E. Hallyn
2011-02-28 23:40 ` [PATCH 04/10] Introduce vfs_fcntl() helper ntl
2011-04-03 18:57 ` Serge E. Hallyn
2011-02-28 23:40 ` [PATCH 05/10] Core checkpoint/restart support code ntl
2011-04-03 19:03 ` Serge E. Hallyn
2011-04-04 15:00 ` Nathan Lynch
2011-04-04 15:10 ` Serge E. Hallyn
2011-04-04 15:40 ` Nathan Lynch
2011-04-04 16:27 ` Serge E. Hallyn
2011-04-04 17:32 ` Oren Laadan
2011-04-04 21:43 ` Nathan Lynch
2011-04-04 22:03 ` Serge E. Hallyn
2011-04-04 23:42 ` Dan Smith
2011-04-05 2:17 ` Serge E. Hallyn
2011-04-05 19:18 ` Nathan Lynch
2011-04-04 22:29 ` Matt Helsley [this message]
2011-04-04 17:41 ` Andrew Morton
2011-04-04 18:51 ` Serge E. Hallyn
2011-04-04 19:42 ` Andrew Morton
2011-04-04 20:29 ` Serge E. Hallyn
2011-04-04 21:55 ` Matt Helsley
2011-04-04 23:15 ` Andrew Morton
2011-04-04 23:16 ` Valdis.Kletnieks
2011-04-04 23:43 ` Matt Helsley
2011-04-04 22:11 ` Serge E. Hallyn
2011-04-04 22:53 ` Serge E. Hallyn
2011-04-04 21:20 ` Nathan Lynch
2011-04-04 21:53 ` Serge E. Hallyn
2011-02-28 23:40 ` [PATCH 06/10] Checkpoint/restart mm support ntl
2011-02-28 23:40 ` [PATCH 07/10] Checkpoint/restart vfs support ntl
2011-02-28 23:40 ` [PATCH 08/10] Add generic '->checkpoint' f_op to ext filesystems ntl
2011-02-28 23:40 ` [PATCH 09/10] Add generic '->checkpoint()' f_op to simple char devices ntl
2011-02-28 23:40 ` [PATCH 10/10] x86_32 support for checkpoint/restart ntl
2011-03-01 1:08 ` [RFC 00/10] container-based checkpoint/restart prototype Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110404222914.GB27628@count0.beaverton.ibm.com \
--to=matthltc@us.ibm.com \
--cc=adobriyan@gmail.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntl@pobox.com \
--cc=orenl@cs.columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®