From: Sam Ravnborg <sam@ravnborg.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: benh@kernel.crashing.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: stop exporting irq_map
Date: Wed, 20 Apr 2011 21:31:45 +0200 [thread overview]
Message-ID: <20110420193145.GA15439@merkur.ravnborg.org> (raw)
In-Reply-To: <20110420084449.23741.45580.stgit@ponder>
> +
> irq_hw_number_t virq_to_hw(unsigned int virq)
> {
> return irq_map[virq].hwirq;
> }
> EXPORT_SYMBOL_GPL(virq_to_hw);
General comment...
kernel/irq/* denote the virtual irq numbers "irq".
powerpc uses "virq" for the same.
Sometimes it is confusing that two different names is used
for the same thing.
The intent of this patch is to centralize access to a common data structure,
but this could also be a good candidate for a terminology shift if
this is considered.
"git grep virq" shows a lot of hits - especially in arm, powerpc.
So what I suggest is obviously only a small step in the direction
of using "irq" all over.
Sam
next prev parent reply other threads:[~2011-04-20 19:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 8:45 Grant Likely
2011-04-20 19:31 ` Sam Ravnborg [this message]
2011-04-21 3:58 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110420193145.GA15439@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=benh@kernel.crashing.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®