Re: [PATCH] powerpc: stop exporting irq_map

[Grant Likely <grant.likely@secretlab.ca>]

On Wed, Apr 20, 2011 at 1:31 PM, Sam Ravnborg <sam@ravnborg.org> wrote:
>> +
>>  irq_hw_number_t virq_to_hw(unsigned int virq)
>>  {
>>       return irq_map[virq].hwirq;
>>  }
>>  EXPORT_SYMBOL_GPL(virq_to_hw);
>
> General comment...
> kernel/irq/* denote the virtual irq numbers "irq".
> powerpc uses "virq" for the same.

I might do that, but I'm early in this refactoring work yet so I'm not
entirely sure what the final result is going to look like.  At least
with the 'virq_' prefix I can find the powerpc specific functions that
are candidates for refactoring or replacing.

g.

>
> Sometimes it is confusing that two different names is used
> for the same thing.
>
> The intent of this patch is to centralize access to a common data structure,
> but this could also be a good candidate for a terminology shift if
> this is considered.
>
> "git grep virq" shows a lot of hits - especially in arm, powerpc.
> So what I suggest is obviously only a small step in the direction
> of using "irq" all over.
>
>        Sam
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.