From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Daniel Kiper <dkiper@net-space.pl>
Cc: konrad.wilk@oracle.com, stefano.stabellini@eu.citrix.com,
xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH REPOST] pv-grub: Fix for incorrect dom->p2m_host[] list initialization
Date: Sat, 23 Apr 2011 00:33:32 +0200 [thread overview]
Message-ID: <20110422223331.GB5124@const.famille.thibault.fr> (raw)
In-Reply-To: <20110422212545.GA22846@router-fw-old.local.net-space.pl>
Hello,
Daniel Kiper, le Fri 22 Apr 2011 23:25:45 +0200, a écrit :
> If pfn of newly allocated page is less than currently requested pfn
> then relevant earlier allocated mfn is overwritten which leads to
> domain crash later.
Oops, good catch! And unfortunately it happens seldomly... I guess it
may be the culprit for a fair number of other issues.
> + if (new_pfn < i)
> + for (new_pfn = i; new_pfn < dom->total_pages; ++new_pfn)
> + if (dom->p2m_host[new_pfn] == new_mfn)
> + break;
Instead of looking for the page, which takes a linear time for each page
and thus potentially quadratic time, we should probably rather record
which PFN the MFNs < allocated have been moved to?
Samuel
next prev parent reply other threads:[~2011-04-22 22:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 21:25 Daniel Kiper
2011-04-22 22:33 ` Samuel Thibault [this message]
2011-04-26 14:25 ` [Xen-devel] " Daniel Kiper
2011-04-26 13:42 ` Konrad Rzeszutek Wilk
2011-04-26 14:34 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110422223331.GB5124@const.famille.thibault.fr \
--to=samuel.thibault@ens-lyon.org \
--cc=dkiper@net-space.pl \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®