mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Kiper <dkiper@net-space.pl>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: Daniel Kiper <dkiper@net-space.pl>,
	konrad.wilk@oracle.com, stefano.stabellini@eu.citrix.com,
	xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH REPOST] pv-grub: Fix for incorrect dom->p2m_host[] list initialization
Date: Tue, 26 Apr 2011 16:25:35 +0200	[thread overview]
Message-ID: <20110426142535.GA27417@router-fw-old.local.net-space.pl> (raw)
In-Reply-To: <20110422223331.GB5124@const.famille.thibault.fr>

On Sat, Apr 23, 2011 at 12:33:32AM +0200, Samuel Thibault wrote:
> Hello,
>
> Daniel Kiper, le Fri 22 Apr 2011 23:25:45 +0200, a ?crit :
> > If pfn of newly allocated page is less than currently requested pfn
> > then relevant earlier allocated mfn is overwritten which leads to
> > domain crash later.
>
> Oops, good catch! And unfortunately it happens seldomly... I guess it
> may be the culprit for a fair number of other issues.

I discovered that issue on domU i386. It does not affect x86_64
in my environment. However, as you stated above that issue in some
circumstances could lead to mysterious system crashes or data
corruptions.

> > +	if (new_pfn < i)
> > +		for (new_pfn = i; new_pfn < dom->total_pages; ++new_pfn)
> > +			if (dom->p2m_host[new_pfn] == new_mfn)
> > +				break;
>
> Instead of looking for the page, which takes a linear time for each page
> and thus potentially quadratic time, we should probably rather record
> which PFN the MFNs < allocated have been moved to?

I am going to post new time optimized version
of that patch today or tommorow.

Daniel

  reply	other threads:[~2011-04-26 14:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-22 21:25 Daniel Kiper
2011-04-22 22:33 ` [Xen-devel] " Samuel Thibault
2011-04-26 14:25   ` Daniel Kiper [this message]
2011-04-26 13:42 ` Konrad Rzeszutek Wilk
2011-04-26 14:34   ` Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110426142535.GA27417@router-fw-old.local.net-space.pl \
    --to=dkiper@net-space.pl \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®