* [PATCH] pm / core bugfix: report error return from suspend_enter
@ 2011-04-22 7:22 MyungJoo Ham
2011-04-22 22:13 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: MyungJoo Ham @ 2011-04-22 7:22 UTC (permalink / raw)
To: linux-pm
Cc: linux-kernel, Len Brown, Pavel Machek, Rafael J. Wysocki,
kyungmin.park, myungjoo.ham
The current implementation of suspend-to-RAM returns 0 if there is an
error from suspend_enter() because suspend_devices_and_enter() ignores
the return value from suspend_enter(). This patch addresses this issue
and properly keep the error return from suspend_enter() and let
suspend_devices_and_enter relay the error return.
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
kernel/power/suspend.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
index 2814c32..08515b4 100644
--- a/kernel/power/suspend.c
+++ b/kernel/power/suspend.c
@@ -224,7 +224,7 @@ int suspend_devices_and_enter(suspend_state_t state)
if (suspend_test(TEST_DEVICES))
goto Recover_platform;
- suspend_enter(state);
+ error = suspend_enter(state);
Resume_devices:
suspend_test_start();
--
1.7.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pm / core bugfix: report error return from suspend_enter
2011-04-22 7:22 [PATCH] pm / core bugfix: report error return from suspend_enter MyungJoo Ham
@ 2011-04-22 22:13 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2011-04-22 22:13 UTC (permalink / raw)
To: MyungJoo Ham
Cc: linux-pm, linux-kernel, Len Brown, Pavel Machek, kyungmin.park,
myungjoo.ham
On Friday, April 22, 2011, MyungJoo Ham wrote:
> The current implementation of suspend-to-RAM returns 0 if there is an
> error from suspend_enter() because suspend_devices_and_enter() ignores
> the return value from suspend_enter(). This patch addresses this issue
> and properly keep the error return from suspend_enter() and let
> suspend_devices_and_enter relay the error return.
>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Applied to suspend-2.6/linux-next.
Thanks,
Rafael
> ---
> kernel/power/suspend.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
> index 2814c32..08515b4 100644
> --- a/kernel/power/suspend.c
> +++ b/kernel/power/suspend.c
> @@ -224,7 +224,7 @@ int suspend_devices_and_enter(suspend_state_t state)
> if (suspend_test(TEST_DEVICES))
> goto Recover_platform;
>
> - suspend_enter(state);
> + error = suspend_enter(state);
>
> Resume_devices:
> suspend_test_start();
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-22 22:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-22 7:22 [PATCH] pm / core bugfix: report error return from suspend_enter MyungJoo Ham
2011-04-22 22:13 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®