[PATCH] drivers:misc:ti-st: fix skip remote baud logic

[PATCH] drivers:misc:ti-st: fix skip remote baud logic

[Pavan Savoy]

From: Victor Goldenshtein <victorg@ti.com>

Texas Instruments WiLink connectivity combo chipsets support custom baud
rates over its UART interface.
This can be achieved by sending the change remote baud rate command.
Since the baud rate can be properly set by the user-space on shared
transport the remote chip-side and local host-side baud rate is change
by the User Space Init Manager.

This patch when encounters the same command inside the firmware,
attempts to skip such command since it is handled by the user-space.
The logic to skip the command when it is un-commented is fixed by this
patch.

Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
Signed-off-by: Victor Goldenshtein <victorg@ti.com>
Author:    Victor Goldenshtein <victorg@ti.com>
---
 drivers/misc/ti-st/st_kim.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c
index b4488c8..57c71fa 100644
--- a/drivers/misc/ti-st/st_kim.c
+++ b/drivers/misc/ti-st/st_kim.c
@@ -244,9 +244,9 @@ void skip_change_remote_baud(unsigned char **ptr, long *len)
 		pr_err("invalid action after change remote baud command");
 	} else {
 		*ptr = *ptr + sizeof(struct bts_action) +
-			((struct bts_action *)nxt_action)->size;
+			((struct bts_action *)cur_action)->size;
 		*len = *len - (sizeof(struct bts_action) +
-				((struct bts_action *)nxt_action)->size);
+				((struct bts_action *)cur_action)->size);
 		/* warn user on not commenting these in firmware */
 		pr_warn("skipping the wait event of change remote baud");
 	}
@@ -385,6 +385,8 @@ static long download_firmware(struct kim_data_s *kim_gdata)
 	}
 	/* fw download complete */
 	release_firmware(kim_gdata->fw_entry);
+	if (len != 0)
+		pr_err("%s:failed, script not parsed completely", __func__);
 	return 0;
 }
 
-- 
1.7.0.4

Re: [PATCH] drivers:misc:ti-st: fix skip remote baud logic

[Greg KH]

On Sat, Apr 23, 2011 at 10:38:17AM +0530, Pavan Savoy wrote:
> From: Victor Goldenshtein <victorg@ti.com>
> 
> Texas Instruments WiLink connectivity combo chipsets support custom baud
> rates over its UART interface.
> This can be achieved by sending the change remote baud rate command.
> Since the baud rate can be properly set by the user-space on shared
> transport the remote chip-side and local host-side baud rate is change
> by the User Space Init Manager.
> 
> This patch when encounters the same command inside the firmware,
> attempts to skip such command since it is handled by the user-space.
> The logic to skip the command when it is un-commented is fixed by this
> patch.
> 
> Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
> Signed-off-by: Victor Goldenshtein <victorg@ti.com>
> Author:    Victor Goldenshtein <victorg@ti.com>

There is no such thing as an "Author:" tag.

And I know that Victor didn't sign off on this, you can not just add his
name to this like that, it is not allowed.

So I now need to get this patch from Victor, with him confirming that he
has signed off on it, sorry.

greg k-h

Re: [PATCH] drivers:misc:ti-st: fix skip remote baud logic

[Pavan Savoy]

On Sat, Apr 23, 2011 at 11:11 AM, Greg KH <greg@kroah.com> wrote:
> On Sat, Apr 23, 2011 at 10:38:17AM +0530, Pavan Savoy wrote:
>> From: Victor Goldenshtein <victorg@ti.com>
>>
>> Texas Instruments WiLink connectivity combo chipsets support custom baud
>> rates over its UART interface.
>> This can be achieved by sending the change remote baud rate command.
>> Since the baud rate can be properly set by the user-space on shared
>> transport the remote chip-side and local host-side baud rate is change
>> by the User Space Init Manager.
>>
>> This patch when encounters the same command inside the firmware,
>> attempts to skip such command since it is handled by the user-space.
>> The logic to skip the command when it is un-commented is fixed by this
>> patch.
>>
>> Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
>> Signed-off-by: Victor Goldenshtein <victorg@ti.com>
>> Author:    Victor Goldenshtein <victorg@ti.com>
>
> There is no such thing as an "Author:" tag.
>
> And I know that Victor didn't sign off on this, you can not just add his
> name to this like that, it is not allowed.

Oopsy, Sorry about this one.
I think I saw an out-of-office from victor, I will ask him to mail this one.

Thanks,
Pavan.

> So I now need to get this patch from Victor, with him confirming that he
> has signed off on it, sorry.
>
> greg k-h
>