From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Michael Williamson <michael.williamson@criticallink.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
lrg@slimlogic.co.uk, tiwai@suse.de
Subject: Re: [PATCH] audio: tlv320aic26: fix PLL register configuration
Date: Thu, 28 Apr 2011 22:56:39 +0100 [thread overview]
Message-ID: <20110428215639.GB19535@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1304026377-21829-1-git-send-email-michael.williamson@criticallink.com>
On Thu, Apr 28, 2011 at 05:32:57PM -0400, Michael Williamson wrote:
> - jval = (fsref == 44100) ? 7 : 8;
> - dval = (fsref == 44100) ? 5264 : 1920;
> + jval = fsref / (aic26->mclk / 2048);
> + dval = fsref - jval * (aic26->mclk / 2048);
I'd like some more brackets on this line, especially given the
similarity with the previous line. Otherwise this looks fine if a bit
magic:
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
next prev parent reply other threads:[~2011-04-28 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 21:32 Michael Williamson
2011-04-28 21:56 ` Mark Brown [this message]
2011-04-28 22:17 ` Mike Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110428215639.GB19535@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=michael.williamson@criticallink.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®