mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: lsorense@csclub.uwaterloo.ca (Lennart Sorensen)
To: linux-kernel@vger.kernel.org
Cc: Mingkai Hu <Mingkai.hu@freescale.com>,
	Len Sorensen <lsorense@csclub.uwaterloo.ca>,
	Grant Likely <grant.likely@secretlab.ca>
Subject: spi_fsl_spi broken when compiled as module by b36ece832512c1a0afa54ff0a56d63492a1caf08
Date: Wed, 11 May 2011 11:52:11 -0400	[thread overview]
Message-ID: <20110511155211.GA21349@caffeine.csclub.uwaterloo.ca> (raw)

When code was refactored, spi_fsl_spi now depends on funfcionts in
spi-fsl_lib, but those are not exported symbols so when building as a
module the symbols are missing and the compile fails.

Adding these to spi_fsl_lib.c fixes the compile.

EXPORT_SYMBOL(mpc8xxx_spi_tx_buf_u32);
EXPORT_SYMBOL(mpc8xxx_spi_rx_buf_u32);
EXPORT_SYMBOL(mpc8xxx_spi_tx_buf_u16);
EXPORT_SYMBOL(mpc8xxx_spi_rx_buf_u16);
EXPORT_SYMBOL(mpc8xxx_spi_tx_buf_u8);
EXPORT_SYMBOL(mpc8xxx_spi_rx_buf_u8);
EXPORT_SYMBOL(mpc8xxx_spi_strmode);
EXPORT_SYMBOL(mpc8xxx_spi_probe);
EXPORT_SYMBOL(of_mpc8xxx_spi_probe);
EXPORT_SYMBOL(mpc8xxx_spi_remove);
EXPORT_SYMBOL(to_of_pinfo);

All releases since the refactoring was done would be affected.

-- 
Len Sorensen

             reply	other threads:[~2011-05-11 15:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-11 15:52 Lennart Sorensen [this message]
2011-05-11 17:03 ` Lennart Sorensen
2011-05-12  1:33 ` Hu Mingkai-B21284
2011-05-12 15:11   ` Lennart Sorensen
2011-05-16  2:10     ` Hu Mingkai-B21284
2011-05-16  2:17       ` Randy Dunlap
2011-05-16 16:52       ` Lennart Sorensen
2011-05-16 18:17     ` Grant Likely
2011-05-16 19:52       ` Lennart Sorensen
2011-05-16 20:01         ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110511155211.GA21349@caffeine.csclub.uwaterloo.ca \
    --to=lsorense@csclub.uwaterloo.ca \
    --cc=Mingkai.hu@freescale.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®