From: lsorense@csclub.uwaterloo.ca (Lennart Sorensen)
To: Hu Mingkai-B21284 <B21284@freescale.com>
Cc: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Grant Likely <grant.likely@secretlab.ca>,
Kumar Gala <galak@kernel.crashing.org>
Subject: Re: spi_fsl_spi broken when compiled as module by b36ece832512c1a0afa54ff0a56d63492a1caf08
Date: Thu, 12 May 2011 11:11:13 -0400 [thread overview]
Message-ID: <20110512151113.GE21345@caffeine.csclub.uwaterloo.ca> (raw)
In-Reply-To: <9389EE59E16E9447AFB481039183BCF4117B10@039-SN1MPN1-005.039d.mgd.msft.net>
On Thu, May 12, 2011 at 01:33:55AM +0000, Hu Mingkai-B21284 wrote:
> Please submit a patch to modify it.
OK. Here it is.
--
Len Sorensen
Add missing exports and module license to allow compiling of spi_fsl_*
drivers as modules again. Originally broken by refactoring of code in
b36ece832512c1a0afa54ff0a56d63492a1caf08.
diff --git a/drivers/spi/spi_fsl_lib.c b/drivers/spi/spi_fsl_lib.c
index ff59f42..d7efaac 100644
--- a/drivers/spi/spi_fsl_lib.c
+++ b/drivers/spi/spi_fsl_lib.c
@@ -48,16 +48,23 @@ u32 mpc8xxx_spi_tx_buf_##type(struct mpc8xxx_spi *mpc8xxx_spi) \
}
MPC8XXX_SPI_RX_BUF(u8)
+EXPORT_SYMBOL(mpc8xxx_spi_rx_buf_u8);
MPC8XXX_SPI_RX_BUF(u16)
+EXPORT_SYMBOL(mpc8xxx_spi_rx_buf_u16);
MPC8XXX_SPI_RX_BUF(u32)
+EXPORT_SYMBOL(mpc8xxx_spi_rx_buf_u32);
MPC8XXX_SPI_TX_BUF(u8)
+EXPORT_SYMBOL(mpc8xxx_spi_tx_buf_u8);
MPC8XXX_SPI_TX_BUF(u16)
+EXPORT_SYMBOL(mpc8xxx_spi_tx_buf_u16);
MPC8XXX_SPI_TX_BUF(u32)
+EXPORT_SYMBOL(mpc8xxx_spi_tx_buf_u32);
struct mpc8xxx_spi_probe_info *to_of_pinfo(struct fsl_spi_platform_data *pdata)
{
return container_of(pdata, struct mpc8xxx_spi_probe_info, pdata);
}
+EXPORT_SYMBOL(to_of_pinfo);
void mpc8xxx_spi_work(struct work_struct *work)
{
@@ -116,6 +123,7 @@ const char *mpc8xxx_spi_strmode(unsigned int flags)
}
return "CPU";
}
+EXPORT_SYMBOL(mpc8xxx_spi_strmode);
int mpc8xxx_spi_probe(struct device *dev, struct resource *mem,
unsigned int irq)
@@ -168,6 +176,7 @@ int mpc8xxx_spi_probe(struct device *dev, struct resource *mem,
err:
return ret;
}
+EXPORT_SYMBOL(mpc8xxx_spi_probe);
int __devexit mpc8xxx_spi_remove(struct device *dev)
{
@@ -188,6 +197,7 @@ int __devexit mpc8xxx_spi_remove(struct device *dev)
return 0;
}
+EXPORT_SYMBOL(mpc8xxx_spi_remove);
int __devinit of_mpc8xxx_spi_probe(struct platform_device *ofdev)
{
@@ -234,3 +244,8 @@ err:
kfree(pinfo);
return ret;
}
+EXPORT_SYMBOL(of_mpc8xxx_spi_probe);
+
+MODULE_AUTHOR("Kumar Gala");
+MODULE_DESCRIPTION("Freescale SPI/eSPI controller driver library");
+MODULE_LICENSE("GPL");
next prev parent reply other threads:[~2011-05-12 15:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 15:52 Lennart Sorensen
2011-05-11 17:03 ` Lennart Sorensen
2011-05-12 1:33 ` Hu Mingkai-B21284
2011-05-12 15:11 ` Lennart Sorensen [this message]
2011-05-16 2:10 ` Hu Mingkai-B21284
2011-05-16 2:17 ` Randy Dunlap
2011-05-16 16:52 ` Lennart Sorensen
2011-05-16 18:17 ` Grant Likely
2011-05-16 19:52 ` Lennart Sorensen
2011-05-16 20:01 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110512151113.GE21345@caffeine.csclub.uwaterloo.ca \
--to=lsorense@csclub.uwaterloo.ca \
--cc=B21284@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®