From: Tejun Heo <tj@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Jeff Garzik <jgarzik@pobox.com>
Cc: Michael Leun <lkml20100708@newton.leun.net>,
linux-ide@vger.kernel.org,
Linux PM mailing list <linux-pm@lists.linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Jeff Garzik <jgarzik@pobox.com>, Jian Peng <jipeng2005@gmail.com>
Subject: [PATCH v2.6.38-rc7] Revert "libata: ahci_start_engine compliant to AHCI spec"
Date: Sat, 14 May 2011 12:28:04 +0200 [thread overview]
Message-ID: <20110514102804.GB23665@htj.dyndns.org> (raw)
In-Reply-To: <20110514101807.GA23665@htj.dyndns.org>
This reverts commit 270dac35c26433d06a89150c51e75ca0181ca7e4.
The commits causes command timeouts on AC plug/unplug. It isn't yet
clear why. As the commit was for a single rather obscure controller,
revert the change for now.
The problem was reported and bisected by Gu Rui in bug#34692.
https://bugzilla.kernel.org/show_bug.cgi?id=34692
Also, reported by Rafael and Michael in the following thread.
http://thread.gmane.org/gmane.linux.kernel/1138771
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Gu Rui <chaos.proton@gmail.com>
Reported-by: Rafael J. Wysocki <rjw@sisk.pl>
Reported-by: Michael Leun <lkml20100708@newton.leun.net>
Cc: Jian Peng <jipeng2005@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>
---
As we're already in -rc7, I'm sending the revert patch to both Jeff
and Linus.
Thank you.
drivers/ata/libahci.c | 21 ---------------------
1 files changed, 0 insertions(+), 21 deletions(-)
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index ff9d832..d38c40f 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -561,27 +561,6 @@ void ahci_start_engine(struct ata_port *ap)
{
void __iomem *port_mmio = ahci_port_base(ap);
u32 tmp;
- u8 status;
-
- status = readl(port_mmio + PORT_TFDATA) & 0xFF;
-
- /*
- * At end of section 10.1 of AHCI spec (rev 1.3), it states
- * Software shall not set PxCMD.ST to 1 until it is determined
- * that a functoinal device is present on the port as determined by
- * PxTFD.STS.BSY=0, PxTFD.STS.DRQ=0 and PxSSTS.DET=3h
- *
- * Even though most AHCI host controllers work without this check,
- * specific controller will fail under this condition
- */
- if (status & (ATA_BUSY | ATA_DRQ))
- return;
- else {
- ahci_scr_read(&ap->link, SCR_STATUS, &tmp);
-
- if ((tmp & 0xf) != 0x3)
- return;
- }
/* start DMA */
tmp = readl(port_mmio + PORT_CMD);
--
1.7.1
next prev parent reply other threads:[~2011-05-14 10:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 22:25 AHCI driver problem on SB700/SB800 w/ Acer Ferrari One Rafael J. Wysocki
2011-05-13 12:37 ` AHCI driver problem on ICH (Re: AHCI driver problem on SB700/SB800 w/ Acer Ferrari One) Michael Leun
2011-05-13 16:56 ` Rafael J. Wysocki
2011-05-13 17:39 ` Tejun Heo
2011-05-13 19:54 ` Michael Leun
2011-05-13 20:20 ` Rafael J. Wysocki
2011-05-13 20:22 ` Rafael J. Wysocki
2011-05-13 20:44 ` Rafael J. Wysocki
2011-05-14 2:08 ` Robert Hancock
2011-05-14 10:18 ` Tejun Heo
2011-05-14 10:28 ` Tejun Heo [this message]
2011-05-14 17:47 ` [PATCH v2.6.38-rc7] Revert "libata: ahci_start_engine compliant to AHCI spec" Linus Torvalds
2011-05-14 18:49 ` Jeff Garzik
[not found] ` <BANLkTik1nFKX1Eyov_o0Xd0rr01Si5hSqA@mail.gmail.com>
2011-05-15 9:25 ` Rafael J. Wysocki
2011-05-15 12:20 ` Michael Leun
2011-05-16 17:02 ` Valdis.Kletnieks
[not found] ` <BANLkTin7NgUMXSVyKn6P0TCrFZ5uaaRL1w@mail.gmail.com>
2011-05-18 19:44 ` Rafael J. Wysocki
[not found] ` <BANLkTimZ9pe-FhkJYHTG1Jx8MUPrMHSFbA@mail.gmail.com>
[not found] ` <BANLkTim9_1Xt8oE4awbCO1iKUW96YUOv_A@mail.gmail.com>
2011-05-19 10:19 ` Rafael J. Wysocki
[not found] ` <BANLkTin6+2obBm=+5Kd5Za1Lq-n4UQ-STw@mail.gmail.com>
2011-05-19 21:32 ` Rafael J. Wysocki
[not found] ` <BANLkTikR2E2vb=9_ftLS4pcq0ysje7Rqyg@mail.gmail.com>
2011-05-19 22:03 ` Rafael J. Wysocki
2011-05-20 15:40 ` Valdis.Kletnieks
2011-05-20 15:43 ` Tejun Heo
2011-05-20 18:21 ` Jian Peng
[not found] ` <BANLkTi=iNjWsaYCJqP057FkhAXtab5nS=Q@mail.gmail.com>
2011-05-20 18:25 ` Valdis.Kletnieks
2011-05-22 2:00 ` Jian Peng
2011-05-23 12:13 ` Tejun Heo
2011-05-24 1:04 ` Jian Peng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110514102804.GB23665@htj.dyndns.org \
--to=tj@kernel.org \
--cc=jgarzik@pobox.com \
--cc=jipeng2005@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=lkml20100708@newton.leun.net \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®